Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Docker push works with Podman REST API #451

Merged
merged 1 commit into from Oct 27, 2020

Conversation

manusa
Copy link
Member

@manusa manusa commented Oct 26, 2020

Description

fix: Docker push works with Podman REST API

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

@codecov
Copy link

codecov bot commented Oct 26, 2020

Codecov Report

Merging #451 into master will increase coverage by 0.02%.
The diff coverage is 83.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #451      +/-   ##
============================================
+ Coverage     37.34%   37.37%   +0.02%     
- Complexity     2450     2456       +6     
============================================
  Files           388      389       +1     
  Lines         19104    19108       +4     
  Branches       2793     2794       +1     
============================================
+ Hits           7135     7142       +7     
+ Misses        11120    11117       -3     
  Partials        849      849              
Impacted Files Coverage Δ Complexity Δ
...ice/docker/access/hc/DockerAccessWithHcClient.java 14.09% <ø> (-0.71%) 14.00 <0.00> (ø)
.../config/service/kubernetes/DockerBuildService.java 55.00% <0.00%> (ø) 2.00 <0.00> (ø)
...ker/access/hc/HcChunkedResponseHandlerWrapper.java 100.00% <100.00%> (ø) 6.00 <6.00> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb1c43c...95b28b6. Read the comment docs.

Signed-off-by: Marc Nuri <marc@marcnuri.com>
@sonarcloud
Copy link

sonarcloud bot commented Oct 27, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

85.7% 85.7% Coverage
0.0% 0.0% Duplication

warning The version of Java (1.8.0_131) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants