Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: removed implementations from config/resource -> resource/service #46

Merged
merged 1 commit into from
Jan 17, 2020

Conversation

manusa
Copy link
Member

@manusa manusa commented Jan 15, 2020

#30: decouple jkube-kit-config-resource from Maven

…rvice

Signed-off-by: Marc Nuri <marc@marcnuri.com>
@manusa manusa mentioned this pull request Jan 15, 2020
7 tasks
@codecov
Copy link

codecov bot commented Jan 15, 2020

Codecov Report

Merging #46 into master will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #46      +/-   ##
============================================
- Coverage     24.61%   24.53%   -0.08%     
+ Complexity     1336     1332       -4     
============================================
  Files           325      325              
  Lines         17572    17572              
  Branches       2688     2688              
============================================
- Hits           4325     4312      -13     
- Misses        12750    12763      +13     
  Partials        497      497
Impacted Files Coverage Δ Complexity Δ
...nfig/service/ArtifactResolverServiceMavenImpl.java 20% <ø> (ø) 1 <0> (?)
...ipse/jkube/kit/config/service/JkubeServiceHub.java 88.09% <ø> (ø) 5 <0> (?)
...eclipse/jkube/kit/config/service/PatchService.java 30.98% <ø> (ø) 15 <0> (?)
...t/config/service/openshift/ImageStreamService.java 57.85% <ø> (ø) 15 <0> (?)
...kube/kit/config/service/JkubeServiceException.java 20% <ø> (ø) 1 <0> (?)
...eclipse/jkube/kit/config/service/ApplyService.java 0% <ø> (ø) 0 <0> (?)
...e/jkube/kit/config/service/ClientToolsService.java 0% <ø> (ø) 0 <0> (?)
...onfig/service/kubernetes/KubernetesClientUtil.java 0% <ø> (ø) 0 <0> (?)
...onfig/service/openshift/OpenshiftBuildService.java 52.54% <ø> (ø) 43 <0> (?)
...e/jkube/kit/config/service/PortForwardService.java 57% <ø> (ø) 8 <0> (?)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03040b8...2b99fcc. Read the comment docs.

@rohanKanojia rohanKanojia merged commit 9282f89 into eclipse-jkube:master Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants