Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Apply and Undeploy service use configured namespace #586

Merged
merged 2 commits into from Feb 24, 2021

Conversation

manusa
Copy link
Member

@manusa manusa commented Feb 23, 2021

Description

feat: Apply and Undeploy service use configured Namespace

As opposed to using a property that was read from Maven and passed on
as a System property.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

Signed-off-by: Marc Nuri <marc@marcnuri.com>
@codecov
Copy link

codecov bot commented Feb 23, 2021

Codecov Report

Merging #586 (e0b4b4e) into master (96c960d) will increase coverage by 0.08%.
The diff coverage is 92.85%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #586      +/-   ##
============================================
+ Coverage     42.33%   42.42%   +0.08%     
- Complexity     2873     2880       +7     
============================================
  Files           404      404              
  Lines         19467    19469       +2     
  Branches       2759     2758       -1     
============================================
+ Hits           8241     8259      +18     
+ Misses        10239    10220      -19     
- Partials        987      990       +3     
Impacted Files Coverage Δ Complexity Δ
...clipse/jkube/kit/common/util/KubernetesHelper.java 29.84% <ø> (-0.64%) 62.00 <0.00> (-2.00)
...lipse/jkube/maven/plugin/mojo/build/ApplyMojo.java 73.33% <83.33%> (+2.64%) 11.00 <1.00> (+2.00)
.../jkube/maven/plugin/mojo/develop/UndeployMojo.java 86.36% <87.50%> (+0.64%) 7.00 <2.00> (+2.00)
.../service/kubernetes/KubernetesUndeployService.java 92.72% <100.00%> (-0.26%) 16.00 <0.00> (ø)
...pse/jkube/maven/plugin/mojo/develop/DebugMojo.java 100.00% <100.00%> (+100.00%) 2.00 <1.00> (+2.00)
...lipse/jkube/maven/plugin/mojo/develop/LogMojo.java 100.00% <100.00%> (+100.00%) 3.00 <2.00> (+3.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96c960d...e0b4b4e. Read the comment docs.

@manusa manusa force-pushed the fix/namespace-configuration branch 2 times, most recently from c7d366b to b01e3d2 Compare February 24, 2021 06:22
As opposed to using a property that was read from Maven and passed on
as a System property.

Signed-off-by: Marc Nuri <marc@marcnuri.com>
@sonarcloud
Copy link

sonarcloud bot commented Feb 24, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

91.7% 91.7% Coverage
0.0% 0.0% Duplication

@manusa manusa merged commit cb9c58e into eclipse-jkube:master Feb 24, 2021
@manusa manusa deleted the fix/namespace-configuration branch February 24, 2021 10:28
@manusa
Copy link
Member Author

manusa commented Mar 4, 2021

Relates to #570 #582

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants