New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Apply and Undeploy service use configured namespace #586
Merged
manusa
merged 2 commits into
eclipse-jkube:master
from
manusa:fix/namespace-configuration
Feb 24, 2021
Merged
feat: Apply and Undeploy service use configured namespace #586
manusa
merged 2 commits into
eclipse-jkube:master
from
manusa:fix/namespace-configuration
Feb 24, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marc Nuri <marc@marcnuri.com>
Codecov Report
@@ Coverage Diff @@
## master #586 +/- ##
============================================
+ Coverage 42.33% 42.42% +0.08%
- Complexity 2873 2880 +7
============================================
Files 404 404
Lines 19467 19469 +2
Branches 2759 2758 -1
============================================
+ Hits 8241 8259 +18
+ Misses 10239 10220 -19
- Partials 987 990 +3
Continue to review full report at Codecov.
|
manusa
force-pushed
the
fix/namespace-configuration
branch
2 times, most recently
from
February 24, 2021 06:22
c7d366b
to
b01e3d2
Compare
...s-maven-plugin/plugin/src/main/java/org/eclipse/jkube/maven/plugin/mojo/build/ApplyMojo.java
Show resolved
Hide resolved
manusa
force-pushed
the
fix/namespace-configuration
branch
from
February 24, 2021 06:39
b01e3d2
to
40e1e2e
Compare
As opposed to using a property that was read from Maven and passed on as a System property. Signed-off-by: Marc Nuri <marc@marcnuri.com>
manusa
force-pushed
the
fix/namespace-configuration
branch
from
February 24, 2021 08:30
40e1e2e
to
e0b4b4e
Compare
Kudos, SonarCloud Quality Gate passed! |
rohanKanojia
approved these changes
Feb 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
feat: Apply and Undeploy service use configured Namespace
As opposed to using a property that was read from Maven and passed on
as a System property.
Type of change
test, version modification, documentation, etc.)
Checklist
I have updated the documentation accordingly