Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Problem with plexus detecting target value type for bean injection #62

Merged
merged 1 commit into from
Feb 12, 2020

Conversation

manusa
Copy link
Member

@manusa manusa commented Feb 12, 2020

After the initial Maven decoupling commits, a bug has appeared specific to Plexus injection of generic typed bean values.

This fix allows to inject <configuration><images><image><build><assembly> entries again.

@sonarcloud
Copy link

sonarcloud bot commented Feb 12, 2020

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@manusa
Copy link
Member Author

manusa commented Feb 12, 2020

Related to #58

@codecov
Copy link

codecov bot commented Feb 12, 2020

Codecov Report

Merging #62 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #62      +/-   ##
============================================
- Coverage     24.55%   24.54%   -0.01%     
  Complexity     1334     1334              
============================================
  Files           326      326              
  Lines         17575    17579       +4     
  Branches       2689     2689              
============================================
  Hits           4315     4315              
- Misses        12763    12767       +4     
  Partials        497      497
Impacted Files Coverage Δ Complexity Δ
...it/build/maven/config/MavenBuildConfiguration.java 57.14% <0%> (-22.86%) 1 <0> (ø)
...ube/kit/config/image/build/BuildConfiguration.java 18.81% <0%> (-0.19%) 17 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 110bb6e...60d6a80. Read the comment docs.

Copy link
Member

@rohanKanojia rohanKanojia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ThorntailOc test seems to be failing but I think it's unrelated to this patch

@rohanKanojia rohanKanojia merged commit a7aab0e into eclipse-jkube:master Feb 12, 2020
@manusa manusa deleted the fix/decoupling-bug branch February 12, 2020 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants