Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: QuarkusGenerator packaging configurable from everywhere* #679

Merged
merged 1 commit into from Apr 23, 2021

Conversation

manusa
Copy link
Member

@manusa manusa commented Apr 20, 2021

Description

refactor: QuarkusGenerator packaging configurable from everywhere*

  • Project/Maven properties
  • Application properties (.properties / .yaml)
  • Inference from target/build directory structure

Closes #632

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

@codecov
Copy link

codecov bot commented Apr 20, 2021

Codecov Report

Merging #679 (1863c10) into master (df4f1b2) will increase coverage by 0.07%.
The diff coverage is 91.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #679      +/-   ##
============================================
+ Coverage     43.84%   43.92%   +0.07%     
- Complexity     3016     3029      +13     
============================================
  Files           409      411       +2     
  Lines         19605    19631      +26     
  Branches       2773     2773              
============================================
+ Hits           8596     8622      +26     
- Misses         9994     9995       +1     
+ Partials       1015     1014       -1     
Impacted Files Coverage Δ Complexity Δ
...clipse/jkube/kit/common/util/JKubeProjectUtil.java 13.72% <0.00%> (-0.28%) 5.00 <0.00> (ø)
...n/java/org/eclipse/jkube/quarkus/QuarkusUtils.java 92.59% <90.00%> (-1.86%) 14.00 <8.00> (+5.00) ⬇️
...pse/jkube/quarkus/generator/QuarkusAssemblies.java 90.38% <90.38%> (ø) 7.00 <7.00> (?)
...in/java/org/eclipse/jkube/quarkus/QuarkusMode.java 96.55% <96.55%> (ø) 17.00 <17.00> (?)
...ipse/jkube/quarkus/generator/QuarkusGenerator.java 95.12% <100.00%> (+4.55%) 19.00 <4.00> (-16.00) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df4f1b2...1863c10. Read the comment docs.

@manusa manusa force-pushed the refactor/quarkus branch 2 times, most recently from c6c87b7 to f96cda6 Compare April 23, 2021 08:38
@manusa manusa added this to Review in Sprint #200 Apr 23, 2021
@manusa manusa marked this pull request as ready for review April 23, 2021 08:44
- Project/Maven properties
- Application properties (.properties / .yaml)
- Inference from target/build directory structure

Signed-off-by: Marc Nuri <marc@marcnuri.com>
@sonarcloud
Copy link

sonarcloud bot commented Apr 23, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

92.7% 92.7% Coverage
0.0% 0.0% Duplication

@manusa manusa merged commit 9035594 into eclipse-jkube:master Apr 23, 2021
Sprint #200 automation moved this from Review to Done Apr 23, 2021
@manusa manusa deleted the refactor/quarkus branch April 26, 2021 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Sprint #200
  
Done
Development

Successfully merging this pull request may close these issues.

Add support for Quarkus Fast Jar Packaging
2 participants