Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Helm charts generated for custom resources, even those with same name #690

Merged
merged 1 commit into from May 5, 2021

Conversation

manusa
Copy link
Member

@manusa manusa commented May 3, 2021

Description

fix: Helm charts can be generated for custom resources, even those with same name (different apiGroup)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

@manusa manusa added this to the 1.3.0 milestone May 3, 2021
@manusa manusa added the bug Something isn't working label May 3, 2021
@manusa manusa added this to Review in Sprint #200 May 3, 2021
@codecov
Copy link

codecov bot commented May 3, 2021

Codecov Report

Merging #690 (e2acff8) into master (c9b11d4) will increase coverage by 0.04%.
The diff coverage is 70.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #690      +/-   ##
============================================
+ Coverage     44.42%   44.46%   +0.04%     
- Complexity     3069     3078       +9     
============================================
  Files           410      410              
  Lines         19570    19585      +15     
  Branches       2762     2766       +4     
============================================
+ Hits           8694     8709      +15     
+ Misses         9869     9867       -2     
- Partials       1007     1009       +2     
Impacted Files Coverage Δ Complexity Δ
...rg/eclipse/jkube/kit/common/util/ResourceUtil.java 64.06% <53.84%> (+3.68%) 15.00 <3.00> (+4.00)
.../kit/enricher/api/util/KubernetesResourceUtil.java 38.90% <100.00%> (+0.43%) 55.00 <0.00> (+2.00)
.../eclipse/jkube/kit/resource/service/WriteUtil.java 91.66% <100.00%> (+1.66%) 8.00 <6.00> (+3.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9b11d4...e2acff8. Read the comment docs.

… name

Signed-off-by: Marc Nuri <marc@marcnuri.com>
@sonarcloud
Copy link

sonarcloud bot commented May 5, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

80.0% 80.0% Coverage
0.0% 0.0% Duplication

@manusa manusa merged commit b2a4fb8 into eclipse-jkube:master May 5, 2021
Sprint #200 automation moved this from Review to Done May 5, 2021
@manusa manusa deleted the fix/helm-with-cr branch May 5, 2021 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Sprint #200
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants