Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DockerImage Kind in BuildOutput #710

Merged
merged 5 commits into from Jun 15, 2021

Conversation

eye0fra
Copy link
Contributor

@eye0fra eye0fra commented Jun 3, 2021

Description

Address the issue defined fabric8io/fabric8-maven-plugin#1054

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

@codecov
Copy link

codecov bot commented Jun 3, 2021

Codecov Report

Merging #710 (3de7965) into master (b733594) will increase coverage by 0.01%.
The diff coverage is 75.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #710      +/-   ##
============================================
+ Coverage     45.01%   45.03%   +0.01%     
- Complexity     3127     3134       +7     
============================================
  Files           413      413              
  Lines         19645    19657      +12     
  Branches       2761     2764       +3     
============================================
+ Hits           8843     8852       +9     
- Misses         9791     9793       +2     
- Partials       1011     1012       +1     
Impacted Files Coverage Δ
...clipse/jkube/maven/plugin/mojo/build/PushMojo.java 0.00% <0.00%> (ø)
...be/maven/plugin/mojo/build/OpenshiftBuildMojo.java 0.00% <0.00%> (ø)
...onfig/service/openshift/OpenshiftBuildService.java 53.00% <83.33%> (+0.58%) ⬆️
...e/jkube/kit/config/service/BuildServiceConfig.java 71.42% <100.00%> (+3.00%) ⬆️
...t/config/service/openshift/ImageStreamService.java 57.02% <100.00%> (+0.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b733594...3de7965. Read the comment docs.

@manusa manusa force-pushed the feature/builldconfig-output branch from 52b15fb to bfda760 Compare June 4, 2021 12:47
@eye0fra eye0fra force-pushed the feature/builldconfig-output branch 4 times, most recently from c499b54 to e69a651 Compare June 4, 2021 15:29
@eye0fra eye0fra force-pushed the feature/builldconfig-output branch from e69a651 to 0325f70 Compare June 15, 2021 09:17
@eye0fra eye0fra marked this pull request as ready for review June 15, 2021 11:26
Copy link
Member

@manusa manusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx!

eye0fra and others added 2 commits June 15, 2021 15:11
…onfig/service/openshift/OpenshiftBuildServiceTest.java

Co-authored-by: Rohan Kumar  <rohan.kumar.kanojia@gmail.com>
…onfig/service/openshift/OpenshiftBuildServiceTest.java

Co-authored-by: Rohan Kumar  <rohan.kumar.kanojia@gmail.com>
@sonarcloud
Copy link

sonarcloud bot commented Jun 15, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants