Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch AWS Credentials from AWS SDK/Environment variables #730

Merged
merged 1 commit into from Jun 23, 2021

Conversation

rohanKanojia
Copy link
Member

@rohanKanojia rohanKanojia commented Jun 18, 2021

Description

Add support in AuthConfigFactory to retrieve credentials from
different mechanisms for AWS.

Port of fabric8io/docker-maven-plugin#1311
Port of fabric8io/docker-maven-plugin#1310

Related to #702

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

@codecov
Copy link

codecov bot commented Jun 18, 2021

Codecov Report

Merging #730 (6ff66d1) into master (0af0925) will increase coverage by 0.19%.
The diff coverage is 61.53%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #730      +/-   ##
============================================
+ Coverage     45.09%   45.29%   +0.19%     
- Complexity     3139     3164      +25     
============================================
  Files           413      415       +2     
  Lines         19676    19809     +133     
  Branches       2765     2783      +18     
============================================
+ Hits           8873     8972      +99     
- Misses         9791     9823      +32     
- Partials       1012     1014       +2     
Impacted Files Coverage Δ
...it/build/service/docker/auth/ecr/AwsSdkHelper.java 0.00% <0.00%> (ø)
...g/eclipse/jkube/kit/build/api/auth/AuthConfig.java 52.72% <53.84%> (-8.50%) ⬇️
...rvice/docker/auth/ecr/AwsSdkAuthConfigFactory.java 54.16% <54.16%> (ø)
...t/build/service/docker/auth/AuthConfigFactory.java 57.82% <81.25%> (+18.93%) ⬆️
...ice/docker/access/hc/DockerAccessWithHcClient.java 14.09% <100.00%> (ø)
...ld/service/docker/auth/CredentialHelperClient.java 32.00% <100.00%> (+9.08%) ⬆️
...it/config/service/portforward/PortForwardTask.java 65.21% <0.00%> (-4.35%) ⬇️
...e/jkube/kit/config/service/PortForwardService.java 71.57% <0.00%> (-3.16%) ⬇️
...build/service/docker/auth/ecr/EcrExtendedAuth.java 90.47% <0.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0af0925...6ff66d1. Read the comment docs.

@manusa manusa added this to Review in Sprint #203 Jun 18, 2021
@manusa manusa removed this from Review in Sprint #203 Jun 18, 2021
@rohanKanojia rohanKanojia force-pushed the pr/issue702_followup branch 2 times, most recently from 6e24f09 to d6cbce8 Compare June 18, 2021 15:01
Add support in AuthConfigFactory to retrieve credentials from
different mechanisms for AWS.

Port of fabric8io/docker-maven-plugin#1311
Port of fabric8io/docker-maven-plugin#1310

Related to eclipse-jkube#702

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
@sonarcloud
Copy link

sonarcloud bot commented Jun 22, 2021

Copy link
Member

@manusa manusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx!

@manusa manusa merged commit e5f1554 into eclipse-jkube:master Jun 23, 2021
@manusa manusa added this to Review in Sprint #203 Jun 23, 2021
@manusa manusa moved this from Review to Done in Sprint #203 Jun 23, 2021
@manusa manusa added this to the 1.4.0 milestone Jun 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Sprint #203
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants