Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MQTTS support in the container-management's local connection #80

Merged
merged 12 commits into from Dec 7, 2022
Merged

MQTTS support in the container-management's local connection #80

merged 12 commits into from Dec 7, 2022

Conversation

k-gostev
Copy link
Member

[#8] MQTTS support in the container-management's local connection

  • parameter to set the CA used to sign the certificate of the local MQTT broker
  • an optional device key and certificate, for the case when using device certificate is set as mandatory on the local MQTT broker

Signed-off-by: Kristiyan Gostev kristiyan.gostev@bosch.io

@konstantina-gramatova konstantina-gramatova linked an issue Oct 25, 2022 that may be closed by this pull request
MQTTS support in the container-management's local connection #8
Closed
konstantina-gramatova
konstantina-gramatova suggested changes Oct 31, 2022
View reviewed changes
containerm/daemon/daemon_config.go Outdated Show resolved Hide resolved
containerm/things/things_containers_service_opts.go Outdated Show resolved Hide resolved
things/client/config/tls_config_test.go Outdated Show resolved Hide resolved
things/client/client_config.go Outdated Show resolved Hide resolved
things/client/config/tls_config.go Outdated Show resolved Hide resolved
@k-gostev k-gostev force-pushed the mqtt-tls branch 9 times, most recently from ea78e18 to edc4703 Compare November 1, 2022 13:19
dimitar-dimitrow
dimitar-dimitrow reviewed Nov 1, 2022
View reviewed changes
util/tls/tls_config.go Outdated Show resolved Hide resolved
util/tls/tls_config.go Show resolved Hide resolved
util/tls/tls_config.go Outdated Show resolved Hide resolved
util/tls/tls_config_test.go Outdated Show resolved Hide resolved
things/client/client_config.go Outdated Show resolved Hide resolved
containerm/things/things_containers_service_test.go Outdated Show resolved Hide resolved
containerm/things/things_containers_service_opts.go Outdated Show resolved Hide resolved
containerm/things/things_containers_service_init.go Outdated Show resolved Hide resolved
containerm/daemon/daemon_config.go Outdated Show resolved Hide resolved
util/tls/tls_config_test.go Outdated Show resolved Hide resolved
@k-gostev k-gostev changed the title [#8] MQTTS support in the container-management's local connection MQTTS support in the container-management's local connection Nov 4, 2022
konstantina-gramatova
konstantina-gramatova suggested changes Nov 7, 2022
View reviewed changes
things/client/client_config.go Outdated Show resolved Hide resolved
containerm/daemon/daemon_config.go Outdated Show resolved Hide resolved
containerm/things/things_containers_service_opts.go Outdated Show resolved Hide resolved
things/client/client_config.go Outdated Show resolved Hide resolved
util/tls/tls_config.go Outdated Show resolved Hide resolved
util/tls/tls_config_test.go Outdated Show resolved Hide resolved
util/tls/tls_config_test.go Outdated Show resolved Hide resolved
util/tls/tls_config_test.go Outdated Show resolved Hide resolved
@k-gostev k-gostev force-pushed the mqtt-tls branch 3 times, most recently from ad723ff to 0230a5b Compare November 8, 2022 13:06
konstantina-gramatova
konstantina-gramatova suggested changes Nov 29, 2022
View reviewed changes
things/client/client_config.go Outdated Show resolved Hide resolved
containerm/daemon/daemon_command.go Show resolved Hide resolved
containerm/daemon/daemon_config_default.go Outdated Show resolved Hide resolved
containerm/daemon/daemon_config_util.go Outdated Show resolved Hide resolved
containerm/pkg/testutil/config/daemon-config.json Outdated Show resolved Hide resolved
containerm/daemon/daemon_test.go Show resolved Hide resolved
@k-gostev k-gostev force-pushed the mqtt-tls branch 2 times, most recently from b8da610 to 96b522a Compare November 30, 2022 10:23
konstantina-gramatova
konstantina-gramatova suggested changes Dec 2, 2022
View reviewed changes
things/client/client.go Show resolved Hide resolved
things/client/client.go Outdated Show resolved Hide resolved
util/tls/tls_config_test.go Outdated Show resolved Hide resolved
util/tls/tls_config.go Show resolved Hide resolved
util/tls/tls_config_test.go Outdated Show resolved Hide resolved
util/tls/tls_config_test.go Outdated Show resolved Hide resolved
@k-gostev k-gostev force-pushed the mqtt-tls branch 3 times, most recently from 23e5db1 to 317ca07 Compare December 5, 2022 08:56
konstantina-gramatova
konstantina-gramatova suggested changes Dec 5, 2022
View reviewed changes
util/tls/tls_config.go Outdated Show resolved Hide resolved
util/tls/tls_config.go Outdated Show resolved Hide resolved
util/tls/tls_config.go Outdated Show resolved Hide resolved
util/tls/tls_config_test.go Outdated Show resolved Hide resolved
util/tls/tls_config_test.go Outdated Show resolved Hide resolved
util/tls/tls_config_test.go Outdated Show resolved Hide resolved
util/tls/tls_config.go Outdated Show resolved Hide resolved
konstantina-gramatova
konstantina-gramatova suggested changes Dec 6, 2022
View reviewed changes
util/tls/tls_config_test.go Outdated Show resolved Hide resolved
util/tls/tls_config_test.go Outdated Show resolved Hide resolved
Kristiyan Gostev added 12 commits December 7, 2022 17:52
@konstantina-gramatova
[eclipse-kanto#8] MQTTS support in the container-management's local c…
0ef5d1e 
…onnection

Signed-off-by: Kristiyan Gostev <kristiyan.gostev@bosch.io>
@konstantina-gramatova
Refactor tests and using tlsConfig struct in daemon
9b5f570 
Signed-off-by: Kristiyan Gostev <kristiyan.gostev@bosch.io>
@konstantina-gramatova
Refactor TLSConfig usage
6dbbe57 
Signed-off-by: Kristiyan Gostev <kristiyan.gostev@bosch.io>
@konstantina-gramatova
TLS package renaming
4571169 
Signed-off-by: Kristiyan Gostev <kristiyan.gostev@bosch.io>
@konstantina-gramatova
Addressing comments
6e23c67 
Signed-off-by: Kristiyan Gostev <kristiyan.gostev@bosch.io>
@konstantina-gramatova
Separating public API from utilities
e7d9c30 
Signed-off-by: Kristiyan Gostev <kristiyan.gostev@bosch.io>
@konstantina-gramatova
Add debug logs for tls config
b0eeabf
@konstantina-gramatova
Refactor tlsConfig struct in daemon and add unit test
0b031e5 
Signed-off-by: Kristiyan Gostev <kristiyan.gostev@bosch.io>
@konstantina-gramatova
Refactor unit tests
926fe4e 
Signed-off-by: Kristiyan Gostev <kristiyan.gostev@bosch.io>
@konstantina-gramatova
Refactor TLS util
18eca2d 
Signed-off-by: Kristiyan Gostev <kristiyan.gostev@bosch.io>
@konstantina-gramatova
Refactor tls_config_test
db2198e 
Signed-off-by: Kristiyan Gostev <kristiyan.gostev@bosch.io>
@konstantina-gramatova
Fixing typo in test function
b6f067d 
Signed-off-by: Kristiyan Gostev <kristiyan.gostev@bosch.io>
@konstantina-gramatova konstantina-gramatova merged commit c80a488 into eclipse-kanto:main Dec 7, 2022
@k-gostev k-gostev mentioned this pull request Dec 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@konstantina-gramatova konstantina-gramatova konstantina-gramatova requested changes

@dimitar-dimitrow dimitar-dimitrow dimitar-dimitrow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MQTTS support in the container-management's local connection
3 participants
@k-gostev @konstantina-gramatova @dimitar-dimitrow