Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve primitive types #482

Closed
pluralia opened this issue May 3, 2022 · 2 comments · Fixed by #508
Closed

Improve primitive types #482

pluralia opened this issue May 3, 2022 · 2 comments · Fixed by #508
Assignees
Labels
good first issue Good for newcomers grammar Grammar language related issue types Types related issue validation Validation related issue
Milestone

Comments

@pluralia
Copy link
Contributor

pluralia commented May 3, 2022

  • Add bigint as a built-in type in grammar and make date with a capital letter
PrimitiveType returns string:
    'string' | 'number' | 'boolean' | 'Date' | 'bigint';
  • Validate bigint as a return type of terminal rules
@pluralia pluralia added good first issue Good for newcomers validation Validation related issue grammar Grammar language related issue types Types related issue labels May 3, 2022
@pluralia pluralia added this to the v0.4.0 milestone May 3, 2022
@pluralia
Copy link
Contributor Author

pluralia commented May 3, 2022

Duplicates #199, that also can be considered as a follow-up where it's necessary to implement the default value converter for bigint and date.

@montymxb
Copy link
Contributor

I can take this one :octocat:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers grammar Grammar language related issue types Types related issue validation Validation related issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants