Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(generator): prevent copied syntaxes from being syntaxes child dir #1079

Conversation

Yokozuna59
Copy link
Contributor

When executing the copy:monarch-syntax script, it performs the following:

public/
├── ...
├── syntaxes/                       # old from HelloWorld example
│   ├── language.monarch.js         # old from HelloWorld example
│   ├── language.monarch.js.map     # old from HelloWorld example
│   │
│   └── syntaxes/                   # new from actual grammar
│       ├── language.monarch.js     # new from actual grammar
│       └── language.monarch.js.map # new from actual grammar
└── ...

Whereas is should be:

public/
├── ...
├── syntaxes/                   # new from actual grammar
│   ├── language.monarch.js     # new from actual grammar
│   └── language.monarch.js.map # new from actual grammar
└── ...

Co-authored-by: Mark Sujew <mark.sujew@typefox.io>
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks 👍

@msujew msujew merged commit 7f3fc78 into eclipse-langium:main Jun 23, 2023
3 checks passed
@Yokozuna59 Yokozuna59 deleted the prevent-copy-monarch-syntax-from-being-child-dir branch June 23, 2023 11:53
@spoenemann spoenemann added this to the v2.0.0 milestone Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants