Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit an event after a configuration section was updated #1445

Merged

Conversation

lars-reimann
Copy link
Member

@lars-reimann lars-reimann commented Apr 7, 2024

Closes #1444

The DefaultConfigurationProvider now emits an event after a configuration section was updated.

@lars-reimann lars-reimann force-pushed the configuration-update-event-emitter branch from 5d6f257 to 7419f30 Compare April 7, 2024 15:28
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good, just one comment, see below.

packages/langium/src/workspace/configuration.ts Outdated Show resolved Hide resolved
Co-authored-by: Mark Sujew <mark.sujew@typefox.io>
@msujew msujew merged commit f3321b6 into eclipse-langium:main Apr 8, 2024
4 checks passed
@lars-reimann lars-reimann deleted the configuration-update-event-emitter branch April 9, 2024 07:08
@msujew msujew added this to the v3.1.0 milestone Jun 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Watch configuration provider for updates
2 participants