Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make entry rule explicit #305

Merged
merged 5 commits into from
Nov 18, 2021
Merged

Make entry rule explicit #305

merged 5 commits into from
Nov 18, 2021

Conversation

pluralia
Copy link
Contributor

Closes #68.

spoenemann
spoenemann reviewed Nov 17, 2021
View reviewed changes
Copy link
Contributor

@spoenemann spoenemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good! Just two comments

packages/langium/src/grammar/grammar-util.ts Outdated Show resolved Hide resolved
packages/langium/src/grammar/langium-grammar-validator.ts Outdated Show resolved Hide resolved
spoenemann
spoenemann approved these changes Nov 17, 2021
View reviewed changes
Copy link
Contributor

@spoenemann spoenemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pluralia pluralia merged commit f3b04b4 into main Nov 18, 2021
@spoenemann spoenemann deleted the pluralia/entry-rule branch November 19, 2021 07:27
@spoenemann spoenemann added this to the v0.3.0 milestone Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spoenemann spoenemann spoenemann approved these changes

@msujew msujew Awaiting requested review from msujew

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.3.0
Development

Successfully merging this pull request may close these issues.

Make entry rule explicit
3 participants
@pluralia @spoenemann @msujew