Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show grammar path and line number for parser validation errors #372

Merged
merged 1 commit into from
Jan 20, 2022
Merged

Show grammar path and line number for parser validation errors #372

merged 1 commit into from
Jan 20, 2022

Conversation

spoenemann
Copy link
Contributor

Closes #201. When Chevrotain reports grammar validation errors, they are prefixed with the file path and line number of the corresponding parser rule.

How to verify:

  • Change one of the examples so there is an ambiguity or left-recursion, then run the CLI to see the validation errors.

@spoenemann spoenemann added this to the v0.3.0 milestone Jan 18, 2022
@pluralia pluralia mentioned this pull request Jan 19, 2022
Closed
msujew
msujew approved these changes Jan 20, 2022
View reviewed changes
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, we will continue the mentioned issue in another way.

The changes look good to me!

@spoenemann spoenemann merged commit efd7692 into main Jan 20, 2022
@spoenemann spoenemann deleted the issue201 branch January 20, 2022 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pluralia pluralia pluralia left review comments

@msujew msujew msujew approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.3.0
Development

Successfully merging this pull request may close these issues.

Trace Chevrotain errors to grammar
3 participants
@spoenemann @msujew @pluralia