Configurable folder excludes #519
Conversation
dhuebner
force-pushed
the
dh/exclude-settings-344
branch
from
9267428
to
7233a47
Compare
dhuebner
force-pushed
the
dh/exclude-settings-344
branch
from
86b0ea6
to
e430c58
Compare
dhuebner
changed the title
dhuebner
force-pushed
the
dh/exclude-settings-344
branch
2 times, most recently
from
77a03ed
to
3f554ca
Compare
dhuebner
force-pushed
the
dh/exclude-settings-344
branch
3 times, most recently
from
17f29ae
to
08ce8d0
Compare
| if (parentWsFolder) { | ||
| // create path relative to workspace folder root: /user/foo/workspace/entry.txt -> entry.txt | ||
| const wsFolderPath = URI.parse(parentWsFolder).path + '/'; | ||
| entryPath = entryPath.replace(wsFolderPath, ''); |
There was a problem hiding this comment.
The string operations startsWith and replace seem unsafe to me: they can lead to false matches. Following my recommendation of moving this file to sprotty-vscode, you can use the Node.js path module for path operations.
packages/langium/src/grammar/workspace/grammar-workspace-manager.ts
Outdated
Show resolved
Hide resolved
dhuebner
force-pushed
the
dh/exclude-settings-344
branch
3 times, most recently
from
4bc41ef
to
04eec5d
Compare
|
@dhuebner There's a compilation error in your latest changes |
dhuebner
force-pushed
the
dh/exclude-settings-344
branch
2 times, most recently
from
0630b5d
to
0d6d2a7
Compare
|
@msujew |
packages/langium-vscode/src/language-server/grammar-workspace-manager.ts
Outdated
Show resolved
Hide resolved
| if (parentWsFolder) { | ||
| // create path relative to workspace folder root: /user/foo/workspace/entry.txt -> entry.txt | ||
| const wsFolderPath = URI.parse(parentWsFolder).path + '/'; | ||
| entryPath = entryPath.replace(wsFolderPath, ''); |
There was a problem hiding this comment.
See my previous comment. Could you try using the path module instead of startsWith and replace string operations?
There was a problem hiding this comment.
Well, it doesn't matter which API we would use, we can't recover the missing information about the WorkspaceFolder we are operating on. That means that we can't create a WSFolder relative path.
I think the best is to pass over the WorkspaceFolder, I changed the implementation accordingly
dhuebner
force-pushed
the
dh/exclude-settings-344
branch
from
0d6d2a7
to
2dbbf27
Compare
Introduces a new configuration service.
Configuration service listens for changes of all registered Langium languages. Configurations are updated when user changes the settings (user/workspace). Other services can request configurations using:
getConfiguration(language: string, configuration: string)Each language will have his own settings section, section name is the
<languageId>-settings.Exclude pattern syntax is handled by node-ignore module kaelzhang/node-ignore
For Langium grammar language it allows configuration of excluded folders using vscode settings.
Fixes #344