-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support string escaping #888
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we apply the changes also to the examples and the generator-langium
template?
f2fd822
to
75184b1
Compare
The TextMate generator doesn't handle the new string regexp correctly. The function |
I forgot to fix the tests, I'll look into those. |
75184b1
to
d50ac18
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍
Closes #885:
\
escaping to theSTRING
rule in langium-grammar.langiumconvertString
method of DefaultValueConverter