Skip to content

Commit

Permalink
Revert "Temporary workaround about HELLO_VERIFY_REQUEST protocol vers…
Browse files Browse the repository at this point in the history
…ion."

This reverts commit a29f4c7.
  • Loading branch information
sbernard31 committed Dec 7, 2020
1 parent 6f37492 commit 40aad7c
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 18 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@
import org.eclipse.californium.scandium.DTLSConnector;
import org.eclipse.californium.scandium.config.DtlsConnectorConfig;
import org.eclipse.californium.scandium.config.DtlsConnectorConfig.Builder;
import org.eclipse.californium.scandium.dtls.ProtocolVersion;
import org.eclipse.leshan.client.engine.DefaultRegistrationEngineFactory;
import org.eclipse.leshan.client.engine.RegistrationEngine;
import org.eclipse.leshan.client.engine.RegistrationEngineFactory;
Expand Down Expand Up @@ -276,11 +275,6 @@ protected Connector createSecuredConnector(DtlsConnectorConfig dtlsConfig) {
}
DtlsConnectorConfig incompleteConfig = dtlsConfigBuilder.getIncompleteConfig();

// TODO probably remove this with integration of Cf-2.6.0.
// see : https://github.com/eclipse/californium/pull/1459
if (incompleteConfig.getProtocolVersionForHelloVerifyRequests() == null)
dtlsConfigBuilder.setProtocolVersionForHelloVerifyRequests(ProtocolVersion.VERSION_DTLS_1_2);

// Handle secure address
if (incompleteConfig.getAddress() == null) {
if (localAddress == null) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@
import org.eclipse.californium.scandium.config.DtlsConnectorConfig;
import org.eclipse.californium.scandium.config.DtlsConnectorConfig.Builder;
import org.eclipse.californium.scandium.dtls.CertificateType;
import org.eclipse.californium.scandium.dtls.ProtocolVersion;
import org.eclipse.californium.scandium.dtls.x509.BridgeCertificateVerifier;
import org.eclipse.leshan.core.LwM2m;
import org.eclipse.leshan.core.californium.DefaultEndpointFactory;
Expand Down Expand Up @@ -443,11 +442,6 @@ public LeshanServer build() {
// Set default DTLS setting for Leshan unless user change it.
DtlsConnectorConfig incompleteConfig = dtlsConfigBuilder.getIncompleteConfig();

// TODO probably remove this with integration of Cf-2.6.0.
// see : https://github.com/eclipse/californium/pull/1459
if (incompleteConfig.getProtocolVersionForHelloVerifyRequests() == null)
dtlsConfigBuilder.setProtocolVersionForHelloVerifyRequests(ProtocolVersion.VERSION_DTLS_1_2);

// Handle PSK Store
if (incompleteConfig.getAdvancedPskStore() != null) {
LOG.warn(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@
import org.eclipse.californium.scandium.config.DtlsConnectorConfig;
import org.eclipse.californium.scandium.config.DtlsConnectorConfig.Builder;
import org.eclipse.californium.scandium.dtls.CertificateType;
import org.eclipse.californium.scandium.dtls.ProtocolVersion;
import org.eclipse.californium.scandium.dtls.x509.BridgeCertificateVerifier;
import org.eclipse.leshan.core.LwM2m;
import org.eclipse.leshan.core.californium.DefaultEndpointFactory;
Expand Down Expand Up @@ -444,11 +443,6 @@ public BootstrapHandler create(BootstrapConfigStore store, LwM2mBootstrapRequest
// Set default DTLS setting for Leshan unless user change it.
DtlsConnectorConfig incompleteConfig = dtlsConfigBuilder.getIncompleteConfig();

// TODO probably remove this with integration of Cf-2.6.0.
// see : https://github.com/eclipse/californium/pull/1459
if (incompleteConfig.getProtocolVersionForHelloVerifyRequests() == null)
dtlsConfigBuilder.setProtocolVersionForHelloVerifyRequests(ProtocolVersion.VERSION_DTLS_1_2);

// Handle PSK Store
if (incompleteConfig.getAdvancedPskStore() != null) {
LOG.warn(
Expand Down

0 comments on commit 40aad7c

Please sign in to comment.