-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keep only one JSON dependency #1045
Comments
While I'm waiting for CR of #1098 I will take this task. |
@sbernard31 You said that we should keep GSON only in our demos. You mean subprojects with "-demo" suffix? I found in demos dependencies to leshan-core which uses minimal-json (JsonSerDes). If we want remove minimal-json/gson from non-demo projects, we have to remove it in demos also, I think. |
I will look at this as soon as possible. (I hope this afternoon or tomorrow)
I guess I was not clear enough. In the description of this issue, I try to explain the current state and how we come to this "crappy" situation. (historic reasons/choices which lead to this situation)
"it should remain only in our demos" I didn't mean that we must do that. I wanted to say that AFAIK GSON dependency remains only in demos. (I guess my English is not so good 馃槄, I will change this) So from my point of view the tasks could be :
|
No, I have no strong opinion about JSON library. I think the Jackson is quite popular in java, and if it has required feature (BigInteger) we can keep it. |
About jackson upgrade, #1105 bump it to |
I created PR #1109 |
Signed-off-by: Micha艂 Wadowski <Michal.Wadowski@orange.com> Also-by: Simon Bernard <sbernard@sierrawireless.com>
Signed-off-by: Micha艂 Wadowski <Michal.Wadowski@orange.com> Also-by: Simon Bernard <sbernard@sierrawireless.com>
Signed-off-by: Micha艂 Wadowski <Michal.Wadowski@orange.com> Also-by: Simon Bernard <sbernard@sierrawireless.com>
Signed-off-by: Micha艂 Wadowski <Michal.Wadowski@orange.com> Also-by: Simon Bernard <sbernard@sierrawireless.com>
Done via #1109. 馃憤 |
Currently we depend on 3 JSON libraries 馃槚 :
it should remain only in our demos, currently it is only used in demos)BigInteger
which is needed to support unsigned integer from LWM2M v1.1 but also because minimal-json is not so much active. (e.g.Deadlock during Json / JsonValue class initialization聽ralfstx/minimal-json#88). We have also some hint which could make us thought that Jackson could be faster. The main drawback of jackson the lib is fat (~1,8 Mo vs ~33 ko) but I guess we will live with it. (except if someone propose a better solution 馃く)So there is a lot of Serializer/Deserializer to rewrite with Jackson to be able to remove GSON and minimal-json dependencies
The text was updated successfully, but these errors were encountered: