Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ncsdk 25967 create a new api endpoint for leshan bad server #1609

Conversation

gracedarcy
Copy link

PLEASE TAKE TIME TO READ THIS

(Click on Preview ☝ to read this more comfortably)

Before To create a PR

Maybe better to discuss with the team about the change you want to contribute first by creating a new issue.

Ready to create the PR

Take a look at Contribution Guide.

PR Description

Please include a summary of the change in the PR description.
Also, refer corresponding issue if it exists.

Your PR is not validated ❌

DO NOT CREATE A NEW PR, just fix the current one, See How to Refine your PR.

If you didn't succeed alone, ask for help before to close your PR and create a new one for same issue.

PFnord and others added 5 commits February 7, 2024 12:18
Try catch

Added sleep if false

Moved customtaskrequest

Moves customtask to requests

testing new container

removed downlink stuff

testing new custom task

reverted commit edc4edf
@gracedarcy gracedarcy force-pushed the ncsdk-25967-create-a-new-api-endpoint-for-leshan-bad-server branch from a7a4dfd to 68d107d Compare April 19, 2024 13:23
@sbernard31
Copy link
Contributor

I don't get what is the purpose of this ? Not even a message to explain ? the default template not even read ?

I guess this is a mistake, if I'm wrong please this is not the right way to contribute...

@gracedarcy
Copy link
Author

I don't get what is the purpose of this ? Not even a message to explain ? the default template not even read ?

I guess this is a mistake, if I'm wrong please this is not the right way to contribute...

I'm so sorry it was a total mistake, I'll delete the pr

@gracedarcy gracedarcy closed this Apr 19, 2024
@sbernard31
Copy link
Contributor

I'm so sorry it was a total mistake, I'll delete the pr

No problem. 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants