Read Response with timestamped SenML

[mgdlkundera]

Implementation of read response with timestamped SenML

This aims to implement : #1553

[sbernard31]

I will try to look at this tomorrow.

[sbernard31]

My first quick review.

I didn't checkout / test the code yet.

Do you want to handle timestamped value for ObserveResponse too ?
(I mean for observe response, not notification (notification as already timestamp value)

[sbernard31]

2 seconds timeout is maybe too high ? 1 is enough

[mgdlkundera]

We should leave a 2 seconds timeout, with 1 s we can't get a response

[sbernard31]

1s should be largely enough to get a response using localhost in tests.

So I read the test again and I see that the comment says :

• 3 seconds
• and the timeout value parameter value is 1

But the javadoc says :

 * @param timeoutInMs The global timeout to wait in milliseconds

So it should be 3 seconds and 3000 or 1 seconds and 1000

[sbernard31]

2 seconds timeout is maybe too high ? 1 is enough

(why not just using 1 and TimeUnit.SECONDS)

[sbernard31]

I rebase the code on master and push some fixes.

You could review it if wanted. (I advice to review commit by commit)

We still need to decide :

Do you want to handle timestamped value for ObserveResponse too ?
(I mean for observe response, not notification (notification as already timestamp value)

I didn't have time to test about reducing timeout value but I pretty sure that 3 seconds is not needed