Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LowerLayerSetter class to allow to tweak coap level parameter for requests #876

Merged
merged 1 commit into from
Sep 3, 2020

Conversation

sbernard31
Copy link
Contributor

This aims to implements #875.

An example of use :

// configure reliability parameters
Builder reliabilityParams = ReliabilityLayerParameters.builder();
reliabilityParams.ackRandomFactor(1).ackTimeout(100).ackTimeoutScale(1).maxRetransmit(1);
// send requests
ReadResponse response = server.send(registration,
                                    new ReadRequest("3/0/1"),  
                                    CoapRequestSetter.reliabilitySetter(reliabilityParams), 
                                    timeout);

@sbernard31
Copy link
Contributor Author

The master version (without any backward compatibility stuff and with support for bootstrap server is available at 7a2966a)

*
* @since 1.2
*/
public interface LowerLayerSetter {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WDYT of LowerLayerConfig? with an apply() method

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 sounds good. I will modify it.

@sbernard31
Copy link
Contributor Author

This now integrated in branch 1.x (cf7dbc9 ) with backward compatibility
and in master commit (813d664) without backward compatibility.

@sbernard31 sbernard31 deleted the lowerlayersetter branch September 3, 2020 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants