Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

- fix Lwm2mNodeTextEncoder for ResourcInstance #898

Conversation

zakharenkodmytro
Copy link
Contributor

  • fixed write in BaseInstanceEnabler
  • added tests

Signed-off-by: Dmytro Zakharenko amidum@gmail.com

- fixed write in BaseInstanceEnabler
- added tests

Signed-off-by: Dmytro Zakharenko <amidum@gmail.com>
@sbernard31 sbernard31 merged commit d4f2e5b into eclipse-leshan:master Oct 2, 2020
@sbernard31
Copy link
Contributor

@zakharenkodmytro thx a lot 🙏

Is there more known bug ? and so more PR incoming ?
Do you still need a 2.0.0-M1 version ?

@sbernard31
Copy link
Contributor

(I edited the commit description commit integrated in master : 6948515)

@zakharenkodmytro
Copy link
Contributor Author

zakharenkodmytro commented Oct 2, 2020

@zakharenkodmytro thx a lot 🙏

Is there more known bug ? and so more PR incoming ?
Do you still need a 2.0.0-M1 version ?

@sbernard31 , I dont think so, so far no more issues were found by me.
Yes we do need 2.0.0-M1 version, for now Im just using snapshot version. Let me know if you planning release 2.0.0-M1?

Thanks

@sbernard31
Copy link
Contributor

@zakharenkodmytro, If you think the current master state is OK for you, I can do a release as soon as I get your green light.

@zakharenkodmytro
Copy link
Contributor Author

@zakharenkodmytro, If you think the current master state is OK for you, I can do a release as soon as I get your green light.

That's will be awesome. I using master branch from September 2 or around. I will do testing today with current master branch to see if it is OK, will let you know.

@zakharenkodmytro
Copy link
Contributor Author

zakharenkodmytro commented Oct 6, 2020

Hi @sbernard31 ,
During running configuration server with latest 2.0.0-SNAPSHOT I found next error

``"exception": [{
"message": "class "
org.eclipse.leshan.server.security.SecurityStore "'s signer information does not match signer information of other classes in the same package",
"file": "java.lang.ClassLoader",
"linenumber": "1150",
"method": "checkCerts"
}, {
"message": "class "
org.eclipse.leshan.server.security.SecurityStore "'s signer information does not match signer information of other classes in the same package",
"file": "java.lang.ClassLoader",
"linenumber": "905",
"method": "preDefineClass"

``
Any clue what can be wrong on my side?
Other than that everything seems fine.
Thank you
Dima

@sbernard31
Copy link
Contributor

It sounds to be a jar signature issue :

Deployed Leshan jar are signed.
This error could happen, if there are 2 classes from same package but with different signature.
Generally this happens when you have 2 same package in 2 different jars.

Is it possible that you mix 2.0.0-SNAPSHOT jar from different source ? or your mixed 2.0.0-SNAPSHOT version with another version of Leshan ?

@zakharenkodmytro
Copy link
Contributor Author

It sounds to be a jar signature issue :

Deployed Leshan jar are signed.
This error could happen, if there are 2 classes from same package but with different signature.
Generally this happens when you have 2 same package in 2 different jars.

Is it possible that you mix 2.0.0-SNAPSHOT jar from different source ? or your mixed 2.0.0-SNAPSHOT version with another version of Leshan ?

Might be, we have a lot lib dependencies so maybe somewhere I used another version of snapshot. I will check, anyway I think you good to go with release, what do you think?

@sbernard31
Copy link
Contributor

sbernard31 commented Oct 7, 2020

We will integrate unsigned intege support in this release but it seems there is some missing part #899.
If is it OK for you, I would prefer to integrate this before the release.
This should not be so impacting.

@zakharenkodmytro
Copy link
Contributor Author

zakharenkodmytro commented Oct 7, 2020

We will integrate unsigned intege support in this release but it seems there is some missing part #899.
If is it OK for you, I would prefer to integrate this before the release.
This should not be so impacting.

Absolutely, please feel free to integrate this part, i have no objections. Wonder what features will be in 2.0.0 release, since it partially cover Lwm2m 1.1?

@sbernard31
Copy link
Contributor

Watch : https://search.maven.org/search?q=g:org.eclipse.leshan%20AND%20a:leshan
2.0.0-M1 should be available in next hours.

@zakharenkodmytro
Copy link
Contributor Author

We will integrate unsigned intege support in this release but it seems there is some missing part #899.
If is it OK for you, I would prefer to integrate this before the release.
This should not be so impacting.

Absolutely, please feel free to integrate this part, i have no objections.

Watch : https://search.maven.org/search?q=g:org.eclipse.leshan%20AND%20a:leshan
2.0.0-M1 should be available in next hours.

Great, it is there !!! Thanks a lot, where I can find release notes?
Dima

@sbernard31
Copy link
Contributor

If there is no surprise, I should do it today.

@sbernard31
Copy link
Contributor

Release notes : https://github.com/eclipse/leshan/releases/tag/leshan-2.0.0-M1

@zakharenkodmytro
Copy link
Contributor Author

Release notes : https://github.com/eclipse/leshan/releases/tag/leshan-2.0.0-M1

Thanks for your work, really appreciate it !!! I will test it out next few days and let you know how it is going. Again great milestone!

Dima

@sbernard31
Copy link
Contributor

@zakharenkodmytro, just in case you missed it and you want to share : #830 😉

@zakharenkodmytro
Copy link
Contributor Author

@zakharenkodmytro, just in case you missed it and you want to share : #830 😉

Absolutely, added!

@sbernard31
Copy link
Contributor

sbernard31 commented Oct 8, 2020

🙏 !!
Could I add verizon as Leshan adopter here : https://www.eclipse.org/leshan/#who%20is%20using ?

@zakharenkodmytro
Copy link
Contributor Author

🙏 !!
Could I add verizon as Leshan adopter here : https://www.eclipse.org/leshan/#who%20is%20using ?
Yes, definitely, please add.

@zakharenkodmytro
Copy link
Contributor Author

Hi @sbernard31 , I integrated release to my services and so far all looks good, no issues found :) I will let you know if some bugs will discover. Thanks again

@sbernard31
Copy link
Contributor

I just discover there is the same bug for JSON. (see #913)
I will fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants