Support for proposed folding provider.

[angelozerr]

VSCode provides folding provider for HTML, JSON.

VSCode has defined in their proposed https://github.com/Microsoft/vscode/blob/master/src/vs/vscode.proposed.d.ts#L37

See microsoft/language-server-protocol#418

It should be cool if lsp4j could provide this feature. Thanks!

[angelozerr]

Is there any chance that someone could work on this issue? This folding range is now included in the official spec https://github.com/Microsoft/vscode-languageserver-protocol-foldingprovider/blob/master/protocol.foldingProvider.md

[angelozerr]

Here the official spec https://microsoft.github.io/language-server-protocol/specification#textDocument_foldingRange

[spoenemann]

Is there any chance that someone could work on this issue?

Maybe later this month. Contributions are welcome :-)

[angelozerr]

Thank a lot @spoenemann ! I will give you some feedback when I will implement folding support on client side (with LSP4e) and server side (with my XML Language Server lsp4xml)

Do you know when release of lsp4j will integrate folding support?

[spoenemann]

v0.5.0 is on September 7th. We'll also have a milestone this week that includes it.

[angelozerr]

Thanks @spoenemann !

[angelozerr]

@spoenemann there were a problem in the folding specification which was fixed at microsoft/language-server-protocol@09ecb5e

In other words, you need to rename the TextDocumentService#foldingRanges to remove the 's' of foldingRange like this:

CompletableFuture<List<FoldingRange>> foldingRange(FoldingRangeRequestParams params)

(foldingRanges to foldingRange)

[angelozerr]

Thanks @spoenemann !

[angelozerr]

@spoenemann just to give you feedback I have implemented folding on client side with LSP4E https://bugs.eclipse.org/bugs/show_bug.cgi?id=537706 and it works great (VSCode CSS Language Server folding is working).

For client side, I'm waiting for that 0.5.0 SNAPSHOT release will contain your fix with foldingRange to try it with my XML Language Server written in Java.

[spoenemann]

The current state is already available in the 0.5.0.M1 milestone release.

[angelozerr]

The current state is already available in the 0.5.0.M1 milestone release.

0.5.0 SNAPSHOT is available today. I confirm you that my XML Language Server (server side) works well. Thanks again @spoenemann !