Add file level operations to WorkspaceEdit #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
45 tasks
spoenemann
suggested changes
Feb 26, 2018
| * otherwise it is null. | ||
| * | ||
| */ | ||
| @NonNull |
There was a problem hiding this comment.
The comment implies that this can be null, so the annotation should be removed.
This was referenced Feb 26, 2018
Adds the new ResourceChange change type to WorkspaceEdit also augments the WorkspaceEditCapabilities with the new resourceChanges capability Signed-off-by: Gorkem Ercan <gorkem.ercan@gmail.com>
gorkem
force-pushed
the
resource_changes
branch
from
baf1e42
to
22ef49f
Compare
|
Removed the NonNull annotation. |
spoenemann
approved these changes
Feb 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the new ResourceChange change type to WorkspaceEdit
also augments the WorkspaceEditCapabilities with the
new resourceChanges capability
See also: microsoft/vscode-languageserver-node#295
microsoft/language-server-protocol#272