GitHub action to run builds #706
Conversation
|
Can one of the admins verify this patch? |
There was a problem hiding this comment.
Thanks @mickaelistria for starting this off. If you or others are interested in getting this complete here are my thoughts:
Perhaps you can show these working on your fork so that we can test the changes before we merge the PR?
There are also some additional steps that need to be done to check the PR, you can see current PR configuration in https://ci.eclipse.org/lsp4j/job/lsp4j-github-pullrequests/configure
Specifically needs:
- gradle
publishand flags-PignoreTestFailures=true --refresh-dependencies --continue mvn -f releng/pom.xml --batch-mode --update-snapshots clean install- collecting and reporting test results
.github/workflows/validate.yml
Outdated
| - name: Set up JDK 17 ☕ | ||
| uses: actions/setup-java@v3 | ||
| with: | ||
| java-version: 17 |
There was a problem hiding this comment.
Java version should match what project uses, or at least a Java 8 (or 11, depending on state of #707) needs to be available too IIUC.
.github/workflows/validate.yml
Outdated
| - main | ||
| push: | ||
| branches: | ||
| - main |
There was a problem hiding this comment.
Why limit the branches? I have seen projects do both. We initially did for CDT, but every release I have to keep adding new branches to this list.
mickaelistria
force-pushed
the
github-actions
branch
from
b68882d
to
05f7f8e
Compare
For the moment, just a build that answers yes/no is most of what I can offer. I'm not familiar with Gradle and so on to do more. Also if I'm not mistaken, isn't the mvn only intended to do p2 stuff? |
|
yes mvn just builds the p2 repo. gradle puts test results to https://github.com/eclipse/lsp4j/blob/4bad511eb9471bef9aafc9ad8e7d9c55b6747a25/releng/build.Jenkinsfile#L84 |
|
Lets go with this for now, people can add to it as needed later. |
No description provided.