Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modernize Gradle #781

Merged
merged 1 commit into from
Feb 12, 2024
Merged

Modernize Gradle #781

merged 1 commit into from
Feb 12, 2024

Conversation

cdietrich
Copy link
Contributor

See #776

@cdietrich
Copy link
Contributor Author

TODO: what about ide task

@jonahgraham jonahgraham mentioned this pull request Feb 12, 2024
Merged
@cdietrich cdietrich force-pushed the cd_issue776 branch 3 times, most recently from 9efccb0 to 5ea1173 Compare February 12, 2024 18:44
@jonahgraham
Copy link
Contributor

I'm looking at this now. I think this is fine and we'll leave the bnd upgrade to 7.0 (with its Java 17 requirement) for another day.

@cdietrich
naive attempt to fix #776
e034d59 
Signed-off-by: Christian Dietrich <christian.dietrich.opensource@gmail.com>

fix some gradle deprecations

Signed-off-by: Christian Dietrich <christian.dietrich.opensource@gmail.com>

update to gradle 8.5

Signed-off-by: Christian Dietrich <christian.dietrich.opensource@gmail.com>

downgrade bnd plugin again

Signed-off-by: Christian Dietrich <christian.dietrich.opensource@gmail.com>
@cdietrich
Copy link
Contributor Author

ok i have rebase rebased and squashed. lets see what build says

@cdietrich
Copy link
Contributor Author

@jonahgraham ok to merge before the release?

@jonahgraham
Copy link
Contributor

@jonahgraham ok to merge before the release?

I will review the generated poms/jars to make sure no unexpected changes and I will merge when/if I approve soon.

@cdietrich
Copy link
Contributor Author

opk. cause i need to drop off soon

@jonahgraham jonahgraham merged commit fc5de60 into main Feb 12, 2024
8 checks passed
@jonahgraham jonahgraham deleted the cd_issue776 branch February 12, 2024 19:22
@jonahgraham jonahgraham mentioned this pull request Feb 12, 2024
Closed
@jonahgraham jonahgraham added this to the 0.22.0 milestone Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonahgraham jonahgraham jonahgraham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.22.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cdietrich @jonahgraham