[regression] MavenExecutionContext.execute(MavenProject, MojoExecution, IProgressMonitor) loses the MojoExecution configuration

[fbricon]

In

m2e-core/org.eclipse.m2e.core/src/org/eclipse/m2e/core/internal/embedder/MavenExecutionContext.java

Line 329 in d5c25f9

MojoExecution clone = new MojoExecution(execution.getPlugin(), execution.getGoal(), execution.getExecutionId());

, the mojo execution's clone is incomplete, so the original configuration is not copied over the clone. This nasty regression breaks invocations of custom mojo executions, as used in m2e-wtp (eclipse-m2e/m2e-wtp#23)

[laeubi]

@fbricon can you probably test if just copy over of the config would fix the issue?

[fbricon]

It does work, but I'm trying to understand why the clone was needed in the first place, how that relates to resources:resources failing when a .mvn folder exists (#1150)

[laeubi]

Can you then please open a PR @HannesWell wants to prepare a new release due to other regressions as well and if its easy to mitigate we should include this, everything else can be done/investigated later.

The problem is that mojo executions previously where created and cached but they use the "global" maven context. In that case a wrong classloader is used for them and that then fails (best shown by using a .mvn folder)