Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail to upgrade from java 19 to 20 using "update maven project" dialog #1326

Closed
eitan-rosenberg opened this issue Mar 23, 2023 · 9 comments · Fixed by #1327
Closed

Fail to upgrade from java 19 to 20 using "update maven project" dialog #1326

eitan-rosenberg opened this issue Mar 23, 2023 · 9 comments · Fixed by #1327
Assignees

Comments

@eitan-rosenberg
Copy link

eitan-rosenberg commented Mar 23, 2023

Hello all,

My installation:

  • "Eclipse IDE for Java Developers" (eclipse-java-2023-03-R-win32-x86_64.zip).

  • openjdk-20_windows-x64_bin.zip.

I installed Java 20 Support for Eclipse (https://marketplace.eclipse.org/content/java-20-support-eclipse-2023-03-427)

I am using Maven 3.9.1

Now it's time to upgrade some projects.

My usual procedure (from 2019) is to change the relevant POM properties and then alt-f5 to update the project.

Now the project is NOT change and the only option is to change the execution environment to JavaSE-20 manually.

POM properties
2023-03-23_09-24-31

alt-f5
2023-03-23_11-08-05

Need to change the execution environment to JavaSE-20 manually.
2023-03-23_11-09-57

I also noticed that if I run "update maven project" dialog the project goes back to java 19

@fbricon
Copy link
Contributor

fbricon commented Mar 23, 2023

@fbricon fbricon self-assigned this Mar 23, 2023
@laeubi
Copy link
Member

laeubi commented Mar 23, 2023

@fbricon why not calling org.eclipse.jdt.launching.environments.IExecutionEnvironmentsManager.getExecutionEnvironments() instead of using that loop?

@eitan-rosenberg
Copy link
Author

Wow....
That was fast !!!
I will watch for new developments
Thanks.

@eitan-rosenberg
Copy link
Author

eitan-rosenberg commented Mar 23, 2023

Hi,
How to get the fixed version ?

Update site ?
https://download.eclipse.org/technology/m2e/releases/latest/

@eitan-rosenberg
Copy link
Author

Hi,

Thanks.
Nice code !! (remove a lot of hard coding)
What next ?

@fbricon
Copy link
Contributor

fbricon commented Mar 24, 2023

Once https://ci.eclipse.org/m2e/job/m2e/job/master/569/ completes successfully, you can try the next snapshot build from https://download.eclipse.org/technology/m2e/snapshots/latest/ (check the update site contains today's bits)

@eitan-rosenberg
Copy link
Author

Ok,
I will wait for:
image
To finish.

@fbricon
Copy link
Contributor

fbricon commented Mar 24, 2023

Java 20 support now available from https://download.eclipse.org/technology/m2e/snapshots/latest/

@eitan-rosenberg
Copy link
Author

I think we have a liftoff !!!

Thank you for your efforts.
Have a nice weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants