Target Editor renders Maven target locations using Object.toString()

[sewe]

Noticed this with the latest snapshot (1.18.2.20211011-2139):

Apparently, the Content tab with Group By: Location uses Object.toString() to render the MavenTargetLocation node. 😞

[HannesWell]

@laeubi in case you take care of this label improvement, for the Definition tab I noticed that the element for the new multi dependency target starts with the number of dependencies:

While this mimics the natural language, personally I don't find it very nice as label. The small number is a bit lost between the icon and the remaining text and it also has the effect that those multi Maven-targets are always sorted to the top.

This is just a cosmetic label and of course everybody has a different taste. Nevertheless I want to suggest some alternatives and maybe we end with a better solution :)

• Maven Dependencies - 3
• Maven Dependencies, count: 3
• Maven Modules - 3
• Maven Module Group with 3 Dependencies

[laeubi]

Yeah the problem is that one can't derive a good name from the childs (I first though about something like <id of first child> and n more ...) but the ultimate solution would be to allow giving a name to a group ... I also have to check that this is not a limitation of PDE itself as you can see it only affects the Content tab and I fear that there is simply the label provider not adapting correctly.

[laeubi]

This is a bug in PDE see https://bugs.eclipse.org/bugs/show_bug.cgi?id=576630