Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support war projects using Servlet versions 5 and 6 #20

Merged
merged 1 commit into from Jan 16, 2023

Conversation

nitind
Copy link
Contributor

@nitind nitind commented Jan 15, 2023

No description provided.

@nitind
Copy link
Contributor Author

nitind commented Jan 16, 2023

@fbricon I can't set a Reviewer myself, so I'm not sure what the next step is.

@fbricon fbricon self-requested a review January 16, 2023 08:09
@fbricon fbricon added the enhancement New feature or request label Jan 16, 2023
@fbricon
Copy link
Contributor

fbricon commented Jan 16, 2023

Change looks fine, but I need to look into the failing build though.

@mickaelistria
Copy link
Contributor

I'm taking care of the build stuff.

@fbricon
Copy link
Contributor

fbricon commented Jan 16, 2023

@mickaelistria why isn't the build failing given the plugin version is not bumped in this PR, yet the build is supposedly checking against the baseline:

m2e-wtp/pom.xml

Lines 125 to 141 in b642102

<plugin>
<groupId>org.eclipse.tycho.extras</groupId>
<artifactId>tycho-p2-extras-plugin</artifactId>
<version>${tycho-version}</version>
<executions>
<execution>
<goals>
<goal>compare-version-with-baselines</goal>
</goals>
<configuration>
<baselines>
<baseline>https://download.eclipse.org/m2e-wtp/releases/latest/</baseline>
</baselines>
</configuration>
</execution>
</executions>
</plugin>

@mickaelistria
Copy link
Contributor

Version was already bumpled since last release, in 1319d98

@fbricon
Copy link
Contributor

fbricon commented Jan 16, 2023

Version was already bumpled since last release, in 1319d98

OK my bad, I was certain 1.5.2 was already released.

@fbricon fbricon merged commit 396fcc2 into eclipse-m2e:master Jan 16, 2023
@fbricon
Copy link
Contributor

fbricon commented Jan 16, 2023

Thanks @nitind

@nitind
Copy link
Contributor Author

nitind commented Feb 6, 2023

@fbricon When's the next planned release?

@fbricon
Copy link
Contributor

fbricon commented Feb 15, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants