Bug 582308 Add description information to snapshot history or details

Find SpotBugs warnings Task-Url: https://bugs.eclipse.org/bugs/show_bug.cgi?id=582308 Change-Id: If03744c25b5c94cd4e4cca77eeeb9932c8c88fde
eclipse-mat · Nov 1, 2023 · 2801455 · 2801455
1 parent 0fd4438
commit 2801455
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 5 deletions.
diff --git a/plugins/org.eclipse.mat.ui/src/org/eclipse/mat/ui/internal/views/NotesView.java b/plugins/org.eclipse.mat.ui/src/org/eclipse/mat/ui/internal/views/NotesView.java
@@ -269,7 +269,7 @@ public void partActivated(IWorkbenchPart part)
                     {
                         prefix = new File(input.getSnapshot().getSnapshotInfo().getPrefix());
                     }
-                    else
+                    else if (input != null)
                     {
                         IChangeListener l = new IChangeListener()
                         {

diff --git a/plugins/org.eclipse.mat.ui/src/org/eclipse/mat/ui/snapshot/views/SnapshotOutlinePage.java b/plugins/org.eclipse.mat.ui/src/org/eclipse/mat/ui/snapshot/views/SnapshotOutlinePage.java
@@ -455,10 +455,13 @@ private String getNotes(SnapshotInfo info)
             }
             else
             {
-                // New location
-                String notes = getNotes(new File(pfx));
-                if (notes != null)
-                    return notes;
+                if (pfx != null)
+                {
+                    // New location
+                    String notes = getNotes(new File(pfx));
+                    if (notes != null)
+                        return notes;
+                }
                 // Old location (might be the same)
                 return getNotes(new File(path));
             }