Bug 581932 ArrayIndexOutOfBoundsException in ArrayIntCompressed

on beforePass2 parsing Add debug message if a class address can't be found in beforePass2 parsing. Change-Id: I3acf642d7d47b02dc9c6147b8ead4ed32045c472
eclipse-mat · May 26, 2023 · 5465107 · 5465107
1 parent 8a4b791
commit 5465107
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 0 deletions.
diff --git a/plugins/org.eclipse.mat.hprof/src/org/eclipse/mat/hprof/HprofParserHandlerImpl.java b/plugins/org.eclipse.mat.hprof/src/org/eclipse/mat/hprof/HprofParserHandlerImpl.java
@@ -272,6 +272,13 @@ public void beforePass2(IProgressListener monitor) throws IOException, SnapshotE
             ClassImpl clazz = e.next();
             int index = identifiers0.reverse(clazz.getObjectAddress());
             clazz.setObjectId(index);
+            if (index < 0)
+            {
+                monitor.sendUserMessage(IProgressListener.Severity.ERROR,
+                                MessageUtil.format(Messages.HprofParserHandlerImpl_ClassNotFoundInAddressIndex,
+                                                clazz.getTechnicalName()),
+                                null);
+            }
 
             maxClassId = Math.max(maxClassId, index);
 
@@ -397,6 +404,7 @@ private void addTypesAndDummyStatics()
                                     cl.getFieldDescriptors().toArray(new FieldDescriptor[0]));
                     newcl.setClassInstance(type);
                     // Fix up the existing lookups
+                    // Relies on replacement of a value being safe inside iterator
                     classesByAddress.put(e.getKey(), newcl);
                     List<ClassImpl>nms = classesByName.get(cl.getName());
                     for (int i = 0; i < nms.size(); ++i)

diff --git a/plugins/org.eclipse.mat.hprof/src/org/eclipse/mat/hprof/Messages.java b/plugins/org.eclipse.mat.hprof/src/org/eclipse/mat/hprof/Messages.java
@@ -55,6 +55,7 @@ public class Messages extends NLS
     public static String HprofIndexBuilder_Parsing;
     public static String HprofIndexBuilder_Scanning;
     public static String HprofIndexBuilder_Writing;
+    public static String HprofParserHandlerImpl_ClassNotFoundInAddressIndex;
     public static String HprofParserHandlerImpl_DiscardedObjects;
     public static String HprofParserHandlerImpl_Error_ExpectedClassSegment;
     public static String HprofParserHandlerImpl_Error_MultipleClassInstancesExist;

diff --git a/plugins/org.eclipse.mat.hprof/src/org/eclipse/mat/hprof/messages.properties b/plugins/org.eclipse.mat.hprof/src/org/eclipse/mat/hprof/messages.properties
@@ -49,6 +49,7 @@ HprofIndexBuilder_ExtractingObjects=Extracting objects from {0}
 HprofIndexBuilder_Parsing=Parsing {0}
 HprofIndexBuilder_Scanning=Scanning {0}
 HprofIndexBuilder_Writing=Writing {0}
+HprofParserHandlerImpl_ClassNotFoundInAddressIndex={0} not found in address index
 HprofParserHandlerImpl_DiscardedObjects=Discarded {0} objects taking {1,number} bytes because of discard ratio {2,number,percent} with pattern {3}
 HprofParserHandlerImpl_Error_ExpectedClassSegment=Error: Found instance segment but expected class segment (see FAQ): 0x{0}
 HprofParserHandlerImpl_Error_MultipleClassInstancesExist=multiple class instances exist for {0}