485245: UI freeze in MarketplaceDropAdapter.hookRecursive (2.1s)

Avoid UI freezes when hooking d&d into deeply nested widget trees. Change-Id: I981ad5655ad55799058e11e3c790e2910a6bc932 Signed-off-by: Leif Geiger <geiger@yatta.de>
eclipse-mpc · Feb 25, 2019 · 336a746 · 336a746
1 parent 4906c19
commit 336a746
Showing 1 changed file with 7 additions and 4 deletions.
diff --git a/...clipse.epp.mpc.ui/src/org/eclipse/epp/internal/mpc/ui/wizards/MarketplaceDropAdapter.java b/...clipse.epp.mpc.ui/src/org/eclipse/epp/internal/mpc/ui/wizards/MarketplaceDropAdapter.java
@@ -131,10 +131,13 @@ private void hookRecursive(Control child, DropTargetListener dropListener) {
 		}
 		if (child instanceof Composite) {
 			Composite composite = (Composite) child;
-			Control[] children = composite.getChildren();
-			for (Control control : children) {
-				hookRecursive(control, dropListener);
-			}
+			// Bug 485245 - avoid UI freezes for deeply nested widget trees
+			composite.getDisplay().asyncExec(() -> {
+				Control[] children = composite.getChildren();
+				for (Control control : children) {
+					hookRecursive(control, dropListener);
+				}
+			});
 		}
 	}