Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update eclipse-mylyn.jsonnet #5

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Conversation

merks
Copy link
Contributor

@merks merks commented Dec 4, 2023

Archive (make read-only) org.eclipse.mylyn.docs.

Archive (make read-only) org.eclipse.mylyn.docs.

Signed-off-by: Ed Merks <Ed.Merks@gmail.com>
@merks merks requested review from a team as code owners December 4, 2023 07:15
@merks
Copy link
Contributor Author

merks commented Dec 4, 2023

@akurtakov

Probably this repo should be archived to prevent further changes...

This comment has been minimized.

@akurtakov
Copy link
Contributor

I defer this call to people working on merging .

Copy link

github-actions bot commented Dec 4, 2023

Diff for 7266210:
Printing local diff for configuration at '/home/runner/work/.eclipsefdn/.eclipsefdn/otterdog-configs/otterdog.json'

Actions are indicated with the following symbols:
+   create
!   modify
!   forced update
-   delete

Organization eclipse-mylyn[id=eclipse-mylyn]
  there have been 1 validation infos, enable verbose output with '-v' to to display them.

  
!   repository[name="org.eclipse.mylyn.docs"] {
!     archived                                                 = false -> true
!   }
  
  Plan: 0 to add, 1 to change, 0 to delete.
Showing diff to a canonical version of the configuration at '/home/runner/work/.eclipsefdn/.eclipsefdn/otterdog-configs/otterdog.json'

Organization eclipse-mylyn[id=eclipse-mylyn]

@merks
Copy link
Contributor Author

merks commented Dec 4, 2023

@BeckerFrank

Probably the repo should be read-only now that that is has been merged.

@ruspl-afed

I wonder if there are any other repos that should be archived but have been overlooked as such?

@BeckerFrank
Copy link
Contributor

@BeckerFrank

Probably the repo should be read-only now that that is has been merged.

Yes the repository org.eclipse.mylyn.docs should archived.
What is needed to finish this Pull Request?

@ruspl-afed

I wonder if there are any other repos that should be archived but have been overlooked as such?

@akurtakov : should we also archive the following two Repositories?

  • org.eclipse.mylyn.docs.intent.main
  • org.eclipse.mylyn.docs.vex

@merks
Copy link
Contributor Author

merks commented Dec 4, 2023

This needs to be merged by the foundation staff. They need a project lead to approve of doing that.

So if a project lead adds an approving review that should move the process forward.

@netomi
Copy link
Contributor

netomi commented Dec 4, 2023

if you approve, we can merge that right away and apply the changes.

@merks
Copy link
Contributor Author

merks commented Dec 4, 2023

See what I mean? @netomi is awesomely fast and when I do changes like this for my projects he processes it so fast my head spins. Long live otterdog! 🚀

@akurtakov
Copy link
Contributor

@akurtakov : should we also archive the following two Repositories?

* org.eclipse.mylyn.docs.intent.main

* org.eclipse.mylyn.docs.vex

These have been inactive even before I joined as far as I'm aware so I believe they should be archived.

@merks
Copy link
Contributor Author

merks commented Dec 4, 2023

Note that the attribute can be removed in the future so it’s not a problem to mark something archived and then change your mind later.

Best to archive other things via a separate PR. I just wanted folks to consider it.

Copy link
Contributor

@BeckerFrank BeckerFrank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@netomi netomi merged commit bcb7714 into eclipse-mylyn:main Dec 5, 2023
2 checks passed
@netomi
Copy link
Contributor

netomi commented Dec 5, 2023

change is live.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants