Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge Mylyn Docs git Repository into Mylyn git Repository #315

Closed
4 of 6 tasks
BeckerFrank opened this issue Nov 21, 2023 · 14 comments
Closed
4 of 6 tasks

Merge Mylyn Docs git Repository into Mylyn git Repository #315

BeckerFrank opened this issue Nov 21, 2023 · 14 comments
Milestone

Comments

@BeckerFrank
Copy link
Contributor

BeckerFrank commented Nov 21, 2023

Instead of working on #313 the plan is now first to move the whole Mylyn Docs Repository into the Mylyn Repository.

Here the planed steps.

  • migrate the Repository and make sure that we have a working Workspace setup and a combined Jenkins Build with all combined stages
  • setup Mylyn Docs only GitHub Actions in Mylyn
  • rework the maven definition so that we have one maven build
  • rework the Jenkins files so that we can perform all previous possible steps from one Jenkinsfile
  • rework the p2 Update Sites
  • rework the html Website and GitHub pages to point to the new stuff
BeckerFrank added a commit that referenced this issue Nov 21, 2023
#315 merge mylyn docs
With this pull request we merge the repository mylyn docs into mylyn and setup a new Jenkins pipeline with all the mylyn doc stages and then all mylyn stages. The mylyn.setup is also changed.

This is the base for all the other tasks from #315
BeckerFrank added a commit that referenced this issue Nov 23, 2023
BeckerFrank added a commit that referenced this issue Nov 23, 2023
[#315] Deploy Docs Snapshot was not executed and prepare separate Branch for mylyn.setup tests
@akurtakov
Copy link
Contributor

Should mylyn.docs git repo be archived now? At least smth should be done to note that it should no longer be used.

@merks
Copy link
Contributor

merks commented Nov 24, 2023

I just remembered that the mylyn docs is using the old feature image:

https://github.com/eclipse-mylyn/org.eclipse.mylyn/blob/main/mylyn.docs/wikitext/core/org.eclipse.mylyn.wikitext/feature.gif

rather than the new one:

https://github.com/eclipse-mylyn/org.eclipse.mylyn/blob/main/mylyn.builds/org.eclipse.mylyn.builds.core/mylyn.png

It will of course be good to make that consistently the new one...

@ruspl-afed
Copy link
Contributor

It will of course be good to make that consistently

Great point!
Am I right that this great change regarding consuming Mylyn Docs from this "merged" repository is for the next SimRel 2024-03?

@merks
Copy link
Contributor

merks commented Nov 24, 2023

It seems a little scary late to do it now...

@ruspl-afed
Copy link
Contributor

Do you plan to update Mylyn Docs contribution for SimRel 2023-12 @akurtakov ?

@akurtakov
Copy link
Contributor

@merks do we need such a release for dependencies sake? If not I don't plan to.

@merks
Copy link
Contributor

merks commented Nov 24, 2023

The existing contribution does not result in any duplicates, so I see no compelling reason to create work for yourself.

@ruspl-afed
Copy link
Contributor

@BeckerFrank it seems that your effort to merge Mylyn Docs into Mylyn was not brought to the attention of all the participants well enough, since we still have changes in Mylyn Docs repository. Please announce you plan more widely (perhaps, you can create a dedicated discussion item) and please ensure that we don't have to support two copies of Mylyn Docs.
Since final Mylyn 4.1 drop for SimRel 2023-12 is expected today, it may be ideal timeframe to merge Mylyn and Mylyn Docs into one project.
cc: @merks

@ruspl-afed
Copy link
Contributor

Mylyn Release contribution was done

BeckerFrank added a commit that referenced this issue Dec 2, 2023
BeckerFrank added a commit that referenced this issue Dec 9, 2023
@ruspl-afed
Copy link
Contributor

setup Mylyn Docs only GitHub Actions in Mylyn

I don't think that we need this point @BeckerFrank

@BeckerFrank
Copy link
Contributor Author

setup Mylyn Docs only GitHub Actions in Mylyn

I don't think that we need this point @BeckerFrank

I was thinking that we need to change the https://github.com/eclipse-mylyn page as there is a link to the now archived https://github.com/eclipse-mylyn/org.eclipse.mylyn.docs for new issues.

We may also no longer need the .github page for "global issues and discussions" as we now only have one repository

@ruspl-afed
Copy link
Contributor

Good point. Please take care about this when you have time.

@olberger
Copy link

Instructions for filing issues need to be addressed too. See eclipse-mylyn/.github#36
Hth,

@ruspl-afed ruspl-afed added this to the 4.2.0 milestone Mar 3, 2024
@ruspl-afed
Copy link
Contributor

@BeckerFrank in fact this is done, please extract not yet complete items to a dedicated tickets, if they are still actual.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants