Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

start next Release (Version 4.2.0) #337

Merged
merged 2 commits into from Dec 12, 2023
Merged

start next Release (Version 4.2.0) #337

merged 2 commits into from Dec 12, 2023

Conversation

BeckerFrank
Copy link
Contributor

@BeckerFrank BeckerFrank commented Dec 9, 2023 •
edited

following tasks are included:

  • update Mylyn Version from 4.1.0 to 4.2.0
  • update Mylyn Docs from 3.0.49 to 4.2.0
  • adjust API Baseline to 4.1.0
  • add Mylyn Docs projects to API Baseline
  • reduce some Problem View Warnings
  • update mylyn.setup

ruspl-afed
ruspl-afed approved these changes Dec 10, 2023
View reviewed changes
Copy link
Contributor

@ruspl-afed ruspl-afed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for this effort @BeckerFrank !

@ruspl-afed
Copy link
Contributor

update Mylyn Docs from 3.0.49 to 4.2.0

Do you have any concerns regarding major version increment for Mylyn Docs @merks @akurtakov ?

@merks
Copy link
Contributor

merks commented Dec 10, 2023

You've done it once before. Did anyone complain? ( Other than me. 😱 )

It's mostly a question of who is downstream from the bundle. I only see this in SimRel where only a lower bound is specified:

image

merks
merks approved these changes Dec 10, 2023
View reviewed changes
Copy link
Contributor

@merks merks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cant' really look at 217 changed file sensibly, so I assume it's fine.

@akurtakov
Copy link
Contributor

@leods I would defer to you the question about mylyn docs major version bump.

@ruspl-afed
Copy link
Contributor

Thank you for the information regarding SimRel usages @merks

You've done it once before. Did anyone complain? ( Other than me. 😱 )

Yes, I did.
And it was not my personal voluntary decision, we had an open poll here

@BeckerFrank
Copy link
Contributor Author

I cant' really look at 217 changed file sensibly, so I assume it's fine.

Should I split this in separate pull requests?

@merks
Copy link
Contributor

merks commented Dec 10, 2023

I cant' really look at 217 changed file sensibly, so I assume it's fine.

Should I split this in separate pull requests?

No, we don't need to create more work for you. The massive renumbering is just the way it is and we can assume it's fine. The setup changes look fine too. I'd like to get it all in so I can try it out more easily...

@BeckerFrank
Copy link
Contributor Author

I cant' really look at 217 changed file sensibly, so I assume it's fine.

Should I split this in separate pull requests?

No, we don't need to create more work for you. The massive renumbering is just the way it is and we can assume it's fine. The setup changes look fine too. I'd like to get it all in so I can try it out more easily...

I have created the branch 315-setup-test, which is already a stream "MylynDocs-Setup-Test" in the committed mylyn.setup, so you can test this immediately.

@merks
Copy link
Contributor

merks commented Dec 10, 2023

It mostly looks good at the end:

image

@BeckerFrank
Copy link
Contributor Author

BeckerFrank commented Dec 10, 2023 •
edited

It mostly looks good at the end:

image

Yes, this is only due to the fact that the master version of mylyn.setup is used with API Baseline 3.26 at the first start. Please restart, then the API Baseline will be updated to 4.1.0 and the errors will be gone.

@BeckerFrank
Copy link
Contributor Author

Commit 7db5e0f fix the mylyn.setup problem with the first startup

gnl42
gnl42 reviewed Dec 10, 2023
View reviewed changes
mylyn.context/org.eclipse.mylyn.cdt.tests/data/TestProject/.project
@@ -5,23 +5,7 @@
<projects>
</projects>
<buildSpec>
<buildCommand>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was cdt doing in Mylyn?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have the org.eclipse.mylyn.cdt-feature feature!

gnl42
gnl42 approved these changes Dec 10, 2023
View reviewed changes
Copy link
Contributor

@gnl42 gnl42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@BeckerFrank
Copy link
Contributor Author

@leods I would defer to you the question about mylyn docs major version bump.

@leods: I wait with the merge of this pull request until I get the answer to the question.

@leods
Copy link
Contributor

leods commented Dec 12, 2023

The version update for Docs is fine

@BeckerFrank BeckerFrank merged commit 9947686 into main Dec 12, 2023
3 checks passed
@akurtakov akurtakov deleted the startNextRelease branch December 12, 2023 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merks merks merks approved these changes

@ruspl-afed ruspl-afed ruspl-afed approved these changes

@gnl42 gnl42 gnl42 approved these changes

@wimjongman wimjongman Awaiting requested review from wimjongman

@akurtakov akurtakov Awaiting requested review from akurtakov

@leods leods Awaiting requested review from leods

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@BeckerFrank @ruspl-afed @merks @akurtakov @leods @gnl42