Clean Up: Commons #375 #388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Task-Url: #375
gnl42
requested review from
wimjongman,
akurtakov,
BeckerFrank and
ruspl-afed
|
Hmm, came across some unwanted "static final" transformations. |
|
What I can see is "public static final" being removed in interfaces as these are implicit which is OK IMHO. |
akurtakov
approved these changes
Jan 30, 2024
ruspl-afed
approved these changes
Jan 30, 2024
Good catch. Forgot about that, I don't like having constants in interfaces so it's been a long time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply Clean Up rules to Commons packages
Task-Url: #375