Clean up: Tasks #376 #391
Merged
Clean up: Tasks #376 #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I understand it's easy to run once per module but reviewing 600+ files is just not feasible. As these are generated ones feel free to push them yourself if you're confident but you can't expect anyone to review such PRs - you would have to go to a far more grainer level (patch size) for that. |
|
Yes, it's too much to review. If the build is good and you've glanced at the changes yourself, we can assume it's okay. |
|
Thanks. I mainly just wanted let you now what was going on. And maybe get some feedback on the cleanup results |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean Up: Tasks
Apply cleanup templates to the Tasks modules
Also found some clean up bugs that I've collected and will pass on to the clean up crew