413 resolve light warnings for mylyn tasks #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruspl-afed
reviewed
Feb 5, 2024
There was a problem hiding this comment.
Please follow guidelines for copyright headers
All the rest looks good, except red pipelines.
| @@ -1,5 +1,5 @@ | |||
| /******************************************************************************* | |||
| * Copyright (c) 2004, 2012 Tasktop Technologies and others. | |||
| * Copyright © 2004, 2012, 2024 Tasktop Technologies and others. | |||
There was a problem hiding this comment.
Should be
Copyright (c) 2004, 2024 Tasktop Technologies and others.
There was a problem hiding this comment.
Lovely :) So much to learn.
What are 'red pipelines'?
|
You have compilation problems after resolving deprecations |
|
I don't know what is going on. I have no errors when I build it locally (full test suite) |
gnl42
force-pushed
the
413-resolve-light-warnings-for-mylyn-tasks
branch
from
28aa7fa
to
60e59b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.