414 resolve light warnings for mylyn bugzilla connector #426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akurtakov
approved these changes
Feb 5, 2024
ruspl-afed
reviewed
Feb 5, 2024
There was a problem hiding this comment.
@akurtakov was faster, but please consider my comments @gnl42
| @@ -58,8 +58,6 @@ public static BufferedReader clean(Reader in, File tempFile) { | |||
| content.append(token.toString()); | |||
| } | |||
| } | |||
| content.flush(); | |||
There was a problem hiding this comment.
I would keep this statement
| try (in) { | ||
| inCleaned = XmlCleaner.clean(in, tempFile); | ||
| if (tempFile != null) { | ||
| tempFile.delete(); |
There was a problem hiding this comment.
I'm not sure why this statement was needed right here, but in refactored version it is moved to another location for some reason.
There was a problem hiding this comment.
It made more sense to move the delete() to the final block
ruspl-afed
deleted the
414-resolve-light-warnings-for-mylyn-bugzilla-connector
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.