Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

418 resolve light warnings for mylyn builds #431

Merged
merged 9 commits into from Feb 20, 2024

Conversation

gnl42
Copy link
Contributor

@gnl42 gnl42 commented Feb 8, 2024

If anyone can figure out how to fix the complaints about AbstractBuildEditorPart I would love to see the solution

@gnl42 gnl42 linked an issue Feb 8, 2024 that may be closed by this pull request
Copy link
Contributor

@ruspl-afed ruspl-afed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One UI string to be externalized

Copy link
Contributor

@ruspl-afed ruspl-afed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
LGTM

@ruspl-afed
Copy link
Contributor

If anyone can figure out how to fix the complaints about AbstractBuildEditorPart I would love to see the solution

This is not trivial, since org.eclipse.emf.databinding.IEMFValueProperty ignores type argument from inherited org.eclipse.core.databinding.property.value.IValueProperty

@merks do you know regarding any plans to update "org.eclipse.emf.databinding"?

@merks
Copy link
Contributor

merks commented Feb 20, 2024

do you know regarding any plans to update "org.eclipse.emf.databinding

There are no plans for that.

@ruspl-afed ruspl-afed merged commit 0e98ab5 into main Feb 20, 2024
3 checks passed
@ruspl-afed ruspl-afed deleted the 418-resolve-light-warnings-for-mylyn-builds branch February 20, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resolve "light" warnings for Mylyn Builds
3 participants