Gitlab Connector: cleanup; two more tests; testinstance update to 16.9.0 #438
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did the following.
Rework the arrange ant the assert part of the tests.
for the Assert I add function to better support date / time fields and the avatar_url
two new Tests testGetUsers and testGetGroups
new fields for groups "math_rendering_limits_enabled": and "lock_math_rendering_limits_enabled"
I hope that's okay, if not I can split this into three separate reviews.