Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable bootstrap class sharing by default jdk8 #149

Closed
pshipton opened this issue Nov 28, 2018 · 7 comments
Closed

Enable bootstrap class sharing by default jdk8 #149

pshipton opened this issue Nov 28, 2018 · 7 comments

Comments

@pshipton
Copy link
Member

pshipton commented Nov 28, 2018 •
edited
Loading

Issue or pull request number:
eclipse-openj9/openj9#3858

Overview:
See #103 and #110. This adds the same changes for jdk8.

Applies to the following JDK versions:
jdk8

Applies to the following platforms:
#103 applies to all jdk8 platforms.
#110 affects all jdk8 platforms but osx
@hangshao0 hangshao0 mentioned this issue Nov 28, 2018
Merged
@hangshao0
Copy link
Contributor

Also the default shared cache and cache snapshot directory is changed to user's home on OpenJ9 Java 8 on non-Windows platforms if -Xshareclasses:groupAccess is not used.

@pshipton
Copy link
Member Author

Re the previous comment, I have updated the description to include this.

doveye added a commit to doveye/openj9-docs that referenced this issue Dec 17, 2018
@doveye
Make "class sharing on by default" doc changes apply to Java 8 as wel…
131d4ca 
…l as Java 11.

eclipse-openj9#149

[skip ci]

Signed-off-by: Esther Dovey <doveye@uk.ibm.com>
@doveye doveye mentioned this issue Dec 17, 2018
Merged
doveye added a commit to doveye/openj9-docs that referenced this issue Dec 17, 2018
@doveye
Make "class sharing on by default" doc changes apply to Java 8 as wel…
ad48636 
…l as Java 11.

eclipse-openj9#149

[skip ci]

Signed-off-by: Esther Dovey <doveye@uk.ibm.com>
@doveye
Copy link
Contributor

doveye commented Dec 17, 2018

The draft doc changes are on an internal server (temporary until we get infrastructure in place at Eclipse to enable multiple simultaneous drafts - work in progress) - please take a look and comment if modifications are required:

@hangshao0
Copy link
Contributor

FYI: This PR will enable bootstrap class sharing by default on OSX (on Java 8 and Java 11+): eclipse-openj9/openj9#4079.

@hangshao0 hangshao0 mentioned this issue Dec 17, 2018
Merged
doveye added a commit to doveye/openj9-docs that referenced this issue Dec 20, 2018
@doveye
Doc changes: bootstrap class sharing enabled by default on all platforms
9abffd3 
macOS recently added. See eclipse-openj9#149

[skip ci]

Signed-off-by: Esther Dovey <doveye@uk.ibm.com>
@doveye doveye mentioned this issue Dec 20, 2018
Merged
@doveye
Copy link
Contributor

doveye commented Dec 20, 2018

I see the PR for macOS has been merged, so I've updated the docs again to remove the macOS-specific content. Draft docs now at:
https://pages.github.ibm.com/runtimes/openj9-docs-staging/174/shrc/
https://pages.github.ibm.com/runtimes/openj9-docs-staging/174/xshareclasses/#cachedir (I assume the cacheDir on macOS is the same as other non-Windows platforms)

@hangshao0
Copy link
Contributor

I assume the cacheDir on macOS is the same as other non-Windows platforms

Correct

@doveye
Copy link
Contributor

doveye commented Dec 20, 2018

Great, think this can be closed now, thanks Hang.

@doveye doveye closed this as completed Dec 20, 2018
@pshipton pshipton mentioned this issue Jun 29, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@doveye @hangshao0 @pshipton