-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doc updates for shared classes cache generation number #866
Merged
pshipton
merged 1 commit into
eclipse-openj9:master
from
ChengJin01:update_doc_shrc_gen_number
Nov 23, 2021
Merged
Doc updates for shared classes cache generation number #866
pshipton
merged 1 commit into
eclipse-openj9:master
from
ChengJin01:update_doc_shrc_gen_number
Nov 23, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The document was updated due to two new fields added to ROMClasss via eclipse-openj9/openj9/pull/13199
Reviewer: @pshipton |
ChengJin01
force-pushed
the
update_doc_shrc_gen_number
branch
from
November 23, 2021 16:33
841a39d
to
f97519d
Compare
hangshao0
reviewed
Nov 23, 2021
ChengJin01
force-pushed
the
update_doc_shrc_gen_number
branch
from
November 23, 2021 16:50
f97519d
to
48430e0
Compare
pshipton
reviewed
Nov 23, 2021
ChengJin01
force-pushed
the
update_doc_shrc_gen_number
branch
2 times, most recently
from
November 23, 2021 17:45
6f7c471
to
703b599
Compare
pshipton
reviewed
Nov 23, 2021
See: eclipse-openj9/openj9/pull/13199 Signed-off-by: Cheng Jin <jincheng@ca.ibm.com>
ChengJin01
force-pushed
the
update_doc_shrc_gen_number
branch
from
November 23, 2021 19:11
703b599
to
eb62f48
Compare
hangshao0
approved these changes
Nov 23, 2021
jenkins doc stage |
pshipton
approved these changes
Nov 23, 2021
We can't stage due to the ongoing network problems at UNB. The link looks correct, I'll just merge this. If there is a problem we can fix it later. |
pshipton
added a commit
to pshipton/openj9
that referenced
this pull request
Jan 18, 2022
See eclipse-openj9/openj9-docs#866 eclipse-openj9#14192 Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
pshipton
added a commit
to pshipton/openj9
that referenced
this pull request
Jan 19, 2022
See eclipse-openj9/openj9-docs#866 eclipse-openj9#14192 Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: eclipse-openj9/openj9/pull/13199
Signed-off-by: Cheng Jin jincheng@ca.ibm.com