Fix compilation issues on zOS (#1639) #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m4 on zOS can not handle C/C++ style comments. This file is included in a C++ header and a few m4 files so the copyright header needs to work for both. Remove the copyright header while a solution is being found. zOS assembler can not handle lines with more than 71 characters even in comments. When a solution is found ensure that the length of each line in the copyright header is a maximum of 71 characters. [ci skip] since this is just removing a copyright header Signed-off-by: Charlie Gracie <charlie.gracie@gmail.com>
|
Pushed this change directly from the command line rather than doing a PR for the OMR sync |
sjkillen
referenced
this pull request
in themaplelab/openj9-omr
Jun 17, 2019
Pull upstream changes and add a traceSelectInliner option
genie-openj9
pushed a commit
that referenced
this pull request
Feb 2, 2021
Tests fail in the following way: ``` 18:26:45 [----------] 450 tests from SelectCompareTest/Int32SelectInt8CompareTest 18:26:45 Assertion failed at /home/jenkins/workspace/Build/compiler/riscv/codegen/OMRTreeEvaluator.cpp:114: false 18:26:45 Opcode bcmpeq is not implemented 18:26:45 18:26:45 compiling file:line:name at level: warm 18:26:45 #0: function TR_LinuxCallStackIterator::printStackBacktrace(TR::Compilation*)+0x2a [0x40017112f4] 18:26:45 #1: function TR_Debug::printStackBacktrace()+0x28 [0x40014f2f42] 18:26:45 #2: ./fvtest/compilertriltest/comptest(+0x133a28e) [0x400133a28e] 18:26:45 #3: ./fvtest/compilertriltest/comptest(+0x133a366) [0x400133a366] 18:26:45 #4: function TR::assertion(char const*, int, char const*, char const*, ...)+0xac [0x400133a416] 18:26:45 #5: function OMR::RV::TreeEvaluator::unImpOpEvaluator(TR::Node*, TR::CodeGenerator*)+0x56 [0x4001523796] 18:26:45 #6: function OMR::CodeGenerator::evaluate(TR::Node*)+0x1a2 [0x4001540254] 18:26:45 #7: function OMR::RV::TreeEvaluator::iselectEvaluator(TR::Node*, TR::CodeGenerator*)+0x6e [0x4001723a96] 18:26:45 #8: function OMR::CodeGenerator::evaluate(TR::Node*)+0x1a2 [0x4001540254] 18:26:45 #9: function genericReturnEvaluator(TR::Node*, OMR::RealRegister::RegNum, TR_RegisterKinds, TR_ReturnInfo, TR::CodeGenerator*)+0x4e [0x4001722790] 18:26:45 #10: function OMR::RV::TreeEvaluator::ireturnEvaluator(TR::Node*, TR::CodeGenerator*)+0x42 [0x40017228c6] 18:26:45 #11: function OMR::CodeGenerator::evaluate(TR::Node*)+0x1a2 [0x4001540254] ``` Signed-off-by: Filip Jeremic <fjeremic@ca.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
m4 on zOS can not handle C/C++ style comments. This file is included in
a C++ header and a few m4 files so the copyright header needs to work
for both. Remove the copyright header while a solution is being found.
zOS assembler can not handle lines with more than 71 characters even in
comments. When a solution is found ensure that the length of each line
in the copyright header is a maximum of 71 characters.
[ci skip] since this is just removing a copyright header
Signed-off-by: Charlie Gracie charlie.gracie@gmail.com