(0.29.1) Prevent OSR transitions from failed guards #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For inlined callee methods that we skip creating HCR guards for, setting createdHCRGuard to false prevents creating an OSR transition point to be taken in cases such as a failed TR_ProfiledGuard. Signed-off-by: Nazim Bhuiyan <nubhuiyan@ibm.com>
0xdaryl
approved these changes
Nov 29, 2021
|
@vijaysun-omr any concerns about merging this? |
|
No concerns from me, I approve of this change as well. |
vijaysun-omr
approved these changes
Nov 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For inlined callee methods that we skip creating HCR guards for,
setting createdHCRGuard to false prevents creating an OSR
transition point to be taken in cases such as a failed
TR_ProfiledGuard.
Port of eclipse/omr#6255 for the 0.29.1 release.
Issue eclipse-openj9/openj9#13162
Signed-off-by: Nazim Bhuiyan nubhuiyan@ibm.com