Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post-restore -Xshareclasses change semantics #16868

Open
dsouzai opened this issue Mar 9, 2023 · 2 comments
Open

Post-restore -Xshareclasses change semantics #16868

dsouzai opened this issue Mar 9, 2023 · 2 comments
Labels
comp:jit comp:vm criu Used to track CRIU snapshot related work

Comments

@dsouzai
Copy link
Contributor

dsouzai commented Mar 9, 2023

This issue tracks what changes can be made via the -Xshareclasses option post-restore. For 0.38, the plan is to introduce -Xshareclasses:disableOnRestore [1] which is a best effort implementation to disable the SCC, and can only be specified post restore [2].

Post 0.38, Some reasonable changes to support may be

  • -Xshareclasses:none to -Xshareclasses:... and vice versa
  • Adding verbose post-restore
  • Modifying sizes via the -Xsc* variants

VM Changes

TBD

JIT Changes

Most changes to -Xshareclasses/-Xsc* don't impact the JIT as all interactions with the SCC are done via APIs. Adding -Xshareclasses:none post-restore is trivial to implement (it is essentially the same work needed to implement -Xshareclasses:disableOnRestore); doing the opposite will be more work and boils down to implementing #16865.


[1] #16714 (comment)
[2] #16714 (comment)

@dsouzai dsouzai added comp:vm comp:jit criu Used to track CRIU snapshot related work labels Mar 9, 2023
@dsouzai
Copy link
Contributor Author

dsouzai commented Mar 9, 2023

@tajila @vijaysun-omr feel free to update the main description as needed.
@hangshao0 fyi.

@hangshao0
Copy link
Contributor

FYI @ehrenjulzert

ehrenjulzert pushed a commit to ehrenjulzert/openj9 that referenced this issue Mar 16, 2023
for eclipse-openj9#16868

Signed-off-by: Ehren Julien-Neitzert <ehren.julien-neitzert@ibm.com>
ehrenjulzert pushed a commit to ehrenjulzert/openj9 that referenced this issue Mar 17, 2023
for eclipse-openj9#16868

Signed-off-by: Ehren Julien-Neitzert <ehren.julien-neitzert@ibm.com>
JasonFengJ9 pushed a commit to JasonFengJ9/openj9 that referenced this issue Mar 17, 2023
for eclipse-openj9#16868

Signed-off-by: Ehren Julien-Neitzert <ehren.julien-neitzert@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:jit comp:vm criu Used to track CRIU snapshot related work
Projects
Status: No status
Development

No branches or pull requests

2 participants