Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable a travis.ci-based PR build for linux x86-64 #24

Closed
DanHeidinga opened this issue Sep 15, 2017 · 7 comments
Closed

Enable a travis.ci-based PR build for linux x86-64 #24

DanHeidinga opened this issue Sep 15, 2017 · 7 comments
Assignees

Comments

@DanHeidinga
Copy link
Member

Build a basic PR build based off the linux_x86-64 docker file.

@mgaudet
Copy link
Contributor

mgaudet commented Sep 21, 2017

This has been enabled, but we're seeing the occasional build failures that look like this

Update openj9 to commit ID: d13eb4bbf02ddc6653524c236b5fd85c5c3264a5
fatal: reference is not a tree: d13eb4bbf02ddc6653524c236b5fd85c5c3264a5
The command "cd openj9-openjdk-jdk9 && bash ./get_source.sh -openj9-repo=$TRAVIS_BUILD_DIR -openj9-branch=$TRAVIS_BRANCH -openj9-sha=$TRAVIS_COMMIT" exited with 128.

https://travis-ci.org/eclipse/openj9/builds/277929812?utm_source=github_status&utm_medium=notification

@mgaudet
Copy link
Contributor

mgaudet commented Sep 21, 2017

Related to #11, one concern w/ travis builds is how to represent dependent changes.

@DanHeidinga
Copy link
Member Author

Regarding the "fatal: reference is not a tree" issue, my understanding is that it is related to force pushes to the repo. The PR build clones (with depth=50) the openj9 repo, merges the PR branch into the master branch, and then we run get_sources trying to checkout at a particular sha as supplied to travis.

If a force push occurs, the sha may not be in the repo any more. See travis-ci/travis-ci#617 for more details.

@DanHeidinga
Copy link
Member Author

Related to #11, one concern w/ travis builds is how to represent dependent changes.

The travis.ci builds are a (hopefully) short term necessity. @AdamBrousseau has recently enabled Jenkins-based PR builds on pLinux & zLinux. Prior to open sourcing, our internal PR builds were able to handle cross repo dependencies so it should just be a matter of time until we've replicated the functionality here.

@AdamBrousseau
Copy link
Contributor

replicated the functionality here.

Done #122

@AdamBrousseau
Copy link
Contributor

I think we should wrap the script commands in set -e & set +e so that we fail fast if any of the commands fail.
See travis-ci/travis-ci#1066

I am going to play around with the checkout (fatal: reference is not a tree) issue. I have a few suspicions.

@DanHeidinga
Copy link
Member Author

Closing this as the compile only travis builds have been available for some time. Thanks to everyone who helped to improve their stability!

tajila pushed a commit to tajila/openj9 that referenced this issue Feb 2, 2018
…-iter-skip

Heed @FrameIteratorSkip in Class, AccessController
tajila pushed a commit to tajila/openj9 that referenced this issue Jul 11, 2019
- added alignedMemory ref in jvmImageHeader
- offset jvmImageHeader to be aligned
- set MAP_FIXED flag for mmap (needs to be page aligned)
- fixed bug on write

Signed-off-by: akshayben akshayben@ibm.com
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants