Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash in NativeCrypto.DigestUpdate (openssl native) #4530

Closed
pshipton opened this issue Jan 31, 2019 · 13 comments
Closed

Crash in NativeCrypto.DigestUpdate (openssl native) #4530

pshipton opened this issue Jan 31, 2019 · 13 comments
Labels
blocker comp:jit userRaised
Milestone
Release 0.12.1

Comments

@pshipton
Copy link
Member 

3XMTHREADINFO3           Java callstack:
4XESTACKTRACE                at jdk/crypto/jniprovider/NativeCrypto.DigestUpdate(Native Method)
4XESTACKTRACE                at sun/security/provider/NativeDigest.engineUpdate(NativeDigest.java:103)
4XESTACKTRACE                at java/security/MessageDigest$Delegate.engineUpdate(MessageDigest.java:613)
4XESTACKTRACE                at java/security/MessageDigest.update(MessageDigest.java:355)
4XESTACKTRACE                at com/sun/crypto/provider/HmacCore.engineUpdate(HmacCore.java:180)
4XESTACKTRACE                at javax/crypto/Mac.update(Mac.java:505)
4XESTACKTRACE                at sun/security/ssl/Authenticator$MacImpl.compute(Authenticator.java:510)
4XESTACKTRACE                at sun/security/ssl/Authenticator$TLS10Mac.compute(Authenticator.java:581)
4XESTACKTRACE                at sun/security/ssl/Authenticator$MAC.compute(Authenticator.java:444)
4XESTACKTRACE                at sun/security/ssl/SSLCipher.addMac(SSLCipher.java:2089)
4XESTACKTRACE                at sun/security/ssl/SSLCipher$T11BlockWriteCipherGenerator$BlockWriteCipher.encrypt(SSLCipher.java:1449)
4XESTACKTRACE                at sun/security/ssl/OutputRecord.t10Encrypt(OutputRecord.java:462)
4XESTACKTRACE                at sun/security/ssl/OutputRecord.encrypt(OutputRecord.java:394)
4XESTACKTRACE                at sun/security/ssl/SSLSocketOutputRecord.encodeAlert(SSLSocketOutputRecord.java:78)
5XESTACKTRACE                   (entered lock: sun/security/ssl/SSLSocketOutputRecord@0x00000000C0C0EDE8, entry count: 2)
4XESTACKTRACE                at sun/security/ssl/TransportContext.warning(TransportContext.java:243)
4XESTACKTRACE                at sun/security/ssl/SSLSocketImpl.duplexCloseOutput(SSLSocketImpl.java:553)
5XESTACKTRACE                   (entered lock: sun/security/ssl/SSLSocketOutputRecord@0x00000000C0C0EDE8, entry count: 1)
4XESTACKTRACE                at sun/security/ssl/SSLSocketImpl.close(SSLSocketImpl.java:479)
4XESTACKTRACE                at sun/security/ssl/BaseSSLSocketImpl.finalize(BaseSSLSocketImpl.java:275)
4XESTACKTRACE                at java/lang/J9VMInternals.runFinalize(J9VMInternals.java:328)
@pshipton pshipton changed the title Crash in NativeCrypto.DigestUpdate Crash in NativeCrypto.DigestUpdate (openssl native) Feb 1, 2019
@pshipton
Copy link
Member Author

pshipton commented Feb 1, 2019

The workaround for this is to disable the openssl digest support.
-Djdk.nativeDigest=false

This was referenced Feb 1, 2019
Merged
Closed
Merged
Closed
pshipton added a commit to pshipton/openj9 that referenced this issue Feb 1, 2019
@pshipton
Update CryptoTest.java to load CipherCore
2bc0739 
MessageDigest openssl support is being disabled due to eclipse-openj9#4530, the test
needs to check a different algorithm.

ibmruntimes/openj9-openjdk-jdk11#117
ibmruntimes/openj9-openjdk-jdk8#259

[ci skip]

Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
@pshipton pshipton mentioned this issue Feb 1, 2019
Merged
pshipton added a commit to pshipton/openj9 that referenced this issue Feb 3, 2019
@pshipton
Update CryptoTest.java to load CipherCore
e0e3bc8 
MessageDigest openssl support is being disabled due to eclipse-openj9#4530, the test
needs to check a different algorithm.

ibmruntimes/openj9-openjdk-jdk11#117
ibmruntimes/openj9-openjdk-jdk8#259

[ci skip]

Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
This was referenced Feb 3, 2019
Merged
Merged
@pshipton pshipton added this to the Release 0.12.1 milestone Feb 3, 2019
@pshipton
Copy link
Member Author

pshipton commented Feb 3, 2019

Fixes are merged.

@pshipton pshipton closed this as completed Feb 3, 2019
SueChaplain added a commit to SueChaplain/openj9-docs that referenced this issue Feb 4, 2019
@SueChaplain
Add warning to version 0.12.0 topic
43708c9 
Following the identification of issue
eclipse-openj9/openj9#4530,
updated the content to warn users that
the Digest algorithm might cause a problem
with this release.

Signed-off-by: Sue Chaplain <sue_chaplain@uk.ibm.com>
@SueChaplain SueChaplain mentioned this issue Feb 4, 2019
Merged
SueChaplain added a commit to SueChaplain/openj9-docs that referenced this issue Feb 4, 2019
@SueChaplain
Add warning to version 0.12.0 topic
b860156 
Following the identification of issue
eclipse-openj9/openj9#4530,
updated the content to warn users that
the Digest algorithm might cause a problem
with this release.

Signed-off-by: Sue Chaplain <sue_chaplain@uk.ibm.com>
@pshipton pshipton mentioned this issue Feb 4, 2019
Merged
SueChaplain added a commit to SueChaplain/openj9-docs that referenced this issue Feb 4, 2019
@SueChaplain
Add warning to version 0.12.0 topic
e867ef7 
Following the identification of issue
eclipse-openj9/openj9#4530,
updated the content to warn users that
the Digest algorithm might cause a problem
with this release.

Signed-off-by: Sue Chaplain <sue_chaplain@uk.ibm.com>
@alon-sh alon-sh mentioned this issue Feb 5, 2019
Closed
@jerrylui803 jerrylui803 mentioned this issue Feb 11, 2019
Closed
@ibm-rtvs
Copy link

I'm seeing this as a regression in:
openjdk version "1.8.0_212"
OpenJDK Runtime Environment (build 1.8.0_212-b03)
Eclipse OpenJ9 VM (build openj9-0.14.0, JRE 1.8.0 Linux amd64-64-Bit Compressed References 20190417_286 (JIT enabled, AOT enabled)
OpenJ9 - bad1d4d
OMR - 4a4278e6
JCL - 5590c4f818 based on jdk8u212-b03)

using the docker image: adoptopenjdk/openjdk8-openj9

@pshipton
Copy link
Member Author

@ashbm5 can you please investigate #4530 (comment)

@ibm-rtvs can you please open a new issue. Until we have one, I'll reopen this one as a reminder.

@pshipton pshipton reopened this Apr 29, 2019
@pshipton
Copy link
Member Author

@vij-singh fyi

@alon-sh
Copy link
Contributor

alon-sh commented Apr 29, 2019

@pshipton are there instructions how can this issue be reproduced? stacktrace? the test put in place to check for this issue is passing

@pshipton
Copy link
Member Author

pshipton commented May 3, 2019

In the absence of a test case, or contact with @ibm-rtvs to get more information, there isn't much we can do.

@pshipton pshipton closed this as completed May 3, 2019
@pshipton
Copy link
Member Author

pshipton commented May 3, 2019

Perhaps not the same, but we do have #5611 opened.

@pshipton
Copy link
Member Author

pshipton commented May 8, 2019 •
edited
Loading

Note the crash reported by ibm-rtvs occurred from the "Finalizer thread".

3XMTHREADINFO3           Java callstack:
4XESTACKTRACE                at jdk/crypto/jniprovider/NativeCrypto.DigestUpdate(Native Method)
4XESTACKTRACE                at sun/security/provider/NativeDigest.engineUpdate(NativeDigest.java:107)
5XESTACKTRACE                   (entered lock: sun/security/provider/NativeSHA5$SHA384@0x00000000FF27EBA0, entry count: 1)
4XESTACKTRACE                at java/security/MessageDigest$Delegate.engineUpdate(MessageDigest.java:584)
4XESTACKTRACE                at java/security/MessageDigest.update(MessageDigest.java:335)
4XESTACKTRACE                at com/sun/crypto/provider/HmacCore.engineUpdate(HmacCore.java:161)
4XESTACKTRACE                at javax/crypto/Mac.update(Mac.java:485)
4XESTACKTRACE                at sun/security/ssl/MAC.compute(MAC.java:133)
4XESTACKTRACE                at sun/security/ssl/OutputRecord.encrypt(OutputRecord.java:237)
4XESTACKTRACE                at sun/security/ssl/SSLSocketImpl.writeRecordInternal(SSLSocketImpl.java:862)
4XESTACKTRACE                at sun/security/ssl/SSLSocketImpl.writeRecord(SSLSocketImpl.java:850)
4XESTACKTRACE                at sun/security/ssl/SSLSocketImpl.writeRecord(SSLSocketImpl.java:720)
4XESTACKTRACE                at sun/security/ssl/SSLSocketImpl.sendAlert(SSLSocketImpl.java:2066)
4XESTACKTRACE                at sun/security/ssl/SSLSocketImpl.warning(SSLSocketImpl.java:1893)
4XESTACKTRACE                at sun/security/ssl/SSLSocketImpl.closeInternal(SSLSocketImpl.java:1656)
5XESTACKTRACE                   (entered lock: sun/security/ssl/SSLSocketImpl@0x00000000FF25AD58, entry count: 1)
4XESTACKTRACE                at sun/security/ssl/SSLSocketImpl.close(SSLSocketImpl.java:1594)
4XESTACKTRACE                at sun/security/ssl/BaseSSLSocketImpl.finalize(BaseSSLSocketImpl.java:269)
4XESTACKTRACE                at java/lang/J9VMInternals.runFinalize(J9VMInternals.java:285(Compiled Code))

@pshipton pshipton reopened this May 8, 2019
@pshipton
Copy link
Member Author

pshipton commented May 9, 2019

Native stack is

#12 <signal handler called>
#13 0x0000000000000025 in ?? ()
#14 0x00007fae3c90adaf in Java_jdk_crypto_jniprovider_NativeCrypto_DigestUpdate ()
   from /root/jdk8u212-b03/jre/lib/amd64/libjncrypto.so

@ashbm5

@alon-sh
Copy link
Contributor

alon-sh commented May 9, 2019

@pshipton looks like the same issue as #5611

@pshipton
Copy link
Member Author

The MessageDigest native crypto has been disabled in the 0.14.2 release branches.
ibmruntimes/openj9-openjdk-jdk8#299
ibmruntimes/openj9-openjdk-jdk11#171

@alon-sh alon-sh mentioned this issue Jun 19, 2019
Merged
@pshipton
Copy link
Member Author

MessageDigest native crypto has been disabled in master.
ibmruntimes/openj9-openjdk-jdk8#318
ibmruntimes/openj9-openjdk-jdk11#190
ibmruntimes/openj9-openjdk-jdk12#59

@keithc-ca keithc-ca mentioned this issue Aug 15, 2019
Closed
@JasonFengJ9 JasonFengJ9 mentioned this issue Dec 29, 2019
Closed
@keithc-ca keithc-ca mentioned this issue Aug 24, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocker comp:jit userRaised
Projects
None yet
Milestone
Release 0.12.1
Development

No branches or pull requests
3 participants
@ibm-rtvs @pshipton @alon-sh