VM marking exit started too early #10273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't indicate exit until after calling Shutdown.shutDown() in DestroyJavaVM. See issue for details. Fixes: eclipse-openj9#10255 [ci skip] Signed-off-by: Graham Chapman <graham_chapman@ca.ibm.com>
|
jenkins test sanity,extended zlinux jdk11 |
|
We should add the hanging test case to the automated tests. |
|
Change looks fine to me and I agree with Pete about adding the test case to the automated runs |
|
I have no idea how to add tests that aren't in the JVMTI framework (which isn't appropriate here), so I suggest merging this and opening a new issue to get the test added. For the record, I modified the test to use wait/notify rather than the latch (which doesn't exist in java 8). This isn't realiable enough to put into an automated test, so perhaps the original test should be added for JDK11+. |
DanHeidinga
approved these changes
Aug 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't indicate exit until after calling Shutdown.shutDown() in
DestroyJavaVM.
See issue for details.
Fixes: #10255
[ci skip]
Signed-off-by: Graham Chapman graham_chapman@ca.ibm.com